After importing translations from po file errors/warnings from po reader are not shown anywhere
I've implemented possible solution and created a patch:
after all lines are read in Gettext::fileToDatabase
Errors from reader are appended to $report array
and then they are printed to watchdog with other messages in locale_translate_batch_finished
I still need to check if line numbers are correct. I think it was something wrong there. But first would be good to get some feedback if it is needed and if it is right solution.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | 1757340.es_.po | 483 bytes | calebtr |
| log_po_import_reader_errors.patch | 3.82 KB | MantasK |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
MantasK commentedThat error
'drupaltestbotmysql.simpletest97109blocked_ips' doesn't exist: SELECT 1 FROM {blocked_ips} WHERE ip = :ip; Array ( [:ip] => 10.20.0.178 )
Doesn't make sense for my patch
Comment #15
smustgrave commentedHave not seen any errors during import of translations? Wonder if this is still an issue in D10?
Comment #17
calebtr commentedI ran into this on a Drupal 10.3 site. From what I see in the 11.x code, it is still an issue.
For me, the specific issue is that in
locale.bulk.inc, exceptions caught inlocale_translate_batch_import()log only generic messages.To replicate:
1. Create a .po file with an error it. I have attached an example.
2. Create a site with the language for the .po file enabled.
3. Attempt to import the .po file at /admin/config/regional/translate/import.
4. See the error, "One translation file could not be imported. See the log for details."
5. See log, no details are included.
What I expect to happen:
Specific error messages are logged. In this case, "The plural formula could not be parsed."
Next steps
The patch in this issue wouldn't apply; it calls watchdog() instead of \Drupal::logger().
I don't see any other places in locale.bulk.inc where a specific error message isn't logged, but I may have missed something and there may be other places in the module.
A simple way to address this is to assign the Exception to a variable and include
$e->getMessage()in the log.Comment #18
calebtr commentedComment #20
calebtr commentedI'm happy to do more work on this at the maintainers' direction.
Comment #21
smustgrave commentedHave not reviewed yet but issue summary appears to be incomplete, recommend using standard template for that. May need test coverage as well.
Comment #22
calebtr commentedI erred on the side of contributing to an existing issue. Would you rather I open a new one?