Supersized formatter [#1757484]

This module allows for integration of Supersized core functionality into Drupal as image formatter.

Project link: http://drupal.org/sandbox/kszyhu/1753332
Git: git clone http://git.drupal.org/sandbox/kszyhu/1753332.git supersized_formatter

Drupal Version: 7.x

Comments

Comment #1

Anonymous (not verified) commented 26 August 2012 at 23:27

Hi !

You are still working in the master branch. Please checkout the following documentation to eliminate this problem. http://drupal.org/empty-git-master

Please checkout the errors pointed out by the automated review : http://ventral.org/pareview/httpgitdrupalorgsandboxkszyhu1753332git

Comment #2

kszyhu commented 27 August 2012 at 09:26

Hi Quentin Albrand,

I made adjustments to the code according to your comments.

Thank you for your feedback.

Comment #3

kszyhu commented 29 August 2012 at 09:02

Status:

Needs work

» Needs review

Comment #4

jrsinclair commented 7 September 2012 at 07:34

Status:

Needs review

» Needs work

Hi kszyhu,

It would be nice if there was a little bit more information on the project page to make it easier to understand what the module does. The screenshot is a great start, but you can find more information on best practices for writing a module page at http://drupal.org/node/997024 and http://growingventuresolutions.com/blog/module-owners-how-make-your-modu...
The file `supersized_formatter.tpl.php` doesn't actually contain any code. Is this deliberate? (I am assuming it is) If so, perhaps a comment explaining why would be useful.
This a minor issue, but it would be nice if the module checked to see if the supersized library was present using the `hook_requirements()` function. Then users would get a helpful message in the status report if they had forgotten to download it. You could even provide a link to the library. If you need some help with this, a number of other modules like Google Analytics and Colorbox operate this way and would have good examples.
I've installed the module, and have it successfully displaying a background image. Should I be able to see links that would change the image? Or is it limited to just changing the background? Either way is fine, but I'd like to know what I should see.

The basic functionality seems to work (unless I should be seeing links), and the code looks relatively clean. I think it just needs a little bit more documentation before release to the public.