Change 'name' to 'id' on View entity

This seems to be a patch which should be postponed until nearly the end of API freeze.

#3: 1757564-id.patch queued for re-testing.

#3: 1757564-id.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.phpundefined
@@ -165,7 +165,7 @@ public function uri() {
    * Overrides Drupal\Core\Entity\EntityInterface::id().
    */
   public function id() {
-    return $this->get('name');
+    return $this->get('id');

We can remove this method now (which was part of the reason to switch)

+++ b/core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.phpundefined
@@ -207,7 +207,7 @@ public function isEnabled() {
   public function getHumanName() {

We should make a separate issue to make this just View::label()

+++ b/core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.phpundefined
@@ -207,7 +207,7 @@ public function isEnabled() {
+      $human_name = $this->get('id');

Let's try to use id() directly

Created #1888390: [Change notice] Change 'human_name' to 'label' and replace View::getHumanName() with View::label()

Let's fix the two most horrible lines in views.

Every other single line of the patch looked perfect!

Great!

#24: 1757564-24.patch queued for re-testing.

Rerolled.

There we go.

Two times the exact same patch.

Tagging, since this brings us in line with the other config entities.

Yay for moar consistency.

Committed and pushed to 8.x. Thanks!

This'll need a tiny change notice.

The change notice: http://drupal.org/node/1893002

Change notice:

-  $view_name = $view->name;
+  $view_name = $view->storage->id();

Patch:

+++ b/core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.php
@@ -48,11 +48,11 @@ class View extends ConfigEntityBase implements ViewStorageInterface {
   /**
-   * The name of the view.
+   * The unique ID of the view.
    *
    * @var string
    */
-  public $name = NULL;
+  public $id = NULL;

Can we now use $view->id() instead?

+++ b/core/modules/views/includes/ajax.inc
@@ -208,7 +208,7 @@ function views_ajax_command_replace_title($title) {
-    'siteName' => config('system.site')->get('name'),
+    'siteName' => config('system.site')->id(),

+++ b/core/modules/views/views.theme.inc
@@ -877,7 +877,7 @@ function template_preprocess_views_view_rss(&$vars) {
   if ($view->display_handler->getOption('sitename_title')) {
-    $title = $config->get('name');
+    $title = $config->id();
     if ($slogan = $config->get('slogan')) {
       $title .= ' - ' . $slogan;

Oops.

EDIT: The first one was already fixed in #1896990: Cannot edit a View's title from the UI.

There we go.

Looks good to me and /rss.xml works again.

Why did tests not break?

Yeah webchick is totally right there are certain pieces of code which does not have test coverage yet.
Working on the follw up: #1903410: Wrong config key is used in template_preprocess_views_view_rss

So we can mark this as fixed, as we have a bugfix for the patch.

Updating title and tags now that we have a change notice.

.