Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
filter.module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Sep 2007 at 23:38 UTC
Updated:
1 Oct 2007 at 09:22 UTC
Jump to comment: Most recent file
Some admin pages for the filter modules don't get any page titles right now. For example: admin/settings/filters/1/configure
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | filter_titles_2.patch | 5.25 KB | pwolanin |
| #2 | filter_titles_1.patch | 4.44 KB | pwolanin |
Comments
Comment #1
pwolanin commentedHmm, someone did a not-so-good job with the module split.
the page at admin/settings/filters/add is non-functional. Patch coming soon.
Comment #2
pwolanin commentedPatch attached.
note - broke out the menu callbacks as separate from the form-building functions, since form building function may be called programatically and thus should not have side effects like setting the page title.
Comment #3
ezra-g commentedThanks for catching this!
This patch did not add a page title for me at admin/settings/filters/1/configure on either the D6B1 tarball or the latest cvs checkout.
Also, at admin/settings/filters/add I got the error:
* notice: Undefined index: filter_admin_format_form in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/includes/form.inc on line 258.
* warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'filter_admin_format_form' was given in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/includes/form.inc on line 271.
I'm respectfully marking it CNW.
Comment #4
pwolanin commented@ezra-g - the new page callbacks will not work unless you first force a menu rebuild. If you don't have devel module installed, just enable or disable a module.
Comment #5
ezra-g commentedOf course. That's my mistake --
After clearing the menu cache, the page title at admin/settings/filters/1/configure displays correctly.
However, at http://localhost/d6b1/drupal/admin/settings/filters/add
I receive:
* notice: Trying to get property of non-object in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/modules/filter/filter.admin.inc on line 97.
* notice: Trying to get property of non-object in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/modules/filter/filter.admin.inc on line 105.
* notice: Trying to get property of non-object in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/modules/filter/filter.admin.inc on line 118.
* notice: Trying to get property of non-object in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/modules/filter/filter.admin.inc on line 118.
* notice: Trying to get property of non-object in /Users/ezra/Documents/Developer/htdocs/d6b1/drupal/modules/filter/filter.admin.inc on line 129.
Comment #6
pwolanin commentedok, I think these notices are from PHP 5 and I'm usually testing on PHP 4.4. I was actually surprised that I didn't see them, since the code is quite sloppy in this regard.
so, i can fix this too, though it's pre-existing and not a consequence of the patch.
Comment #7
dries commentedI fail to understand why this is critical. Critical bugs prevent Drupal from working.
Comment #8
pwolanin commented@Dries - in the absence of this patch you cannot add a new input format at all. So, perhaps that doesn't qualify as critical, but certainly there is basic functionality that's broken.
Comment #9
pwolanin commentedok, added initialization code and other checks to get rid of all the notices while testing on PHP 5.2.
Comment #10
gábor hojtsyConfirmed the issues with a HEAD checkout. Applied your patch and tested the results. I was debating a lot about the 'View' -> 'Edit' tab title change with myself, but the previous state was definitely very inconsistent: /list in the URL, View in the title and then an editing form displayed. So I reached the conclusion that the 'Edit' title and URL change is a good idea. Thanks, committed.
Comment #11
(not verified) commented