Patch (to be ported)
Project:
State Machine
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Aug 2012 at 19:05 UTC
Updated:
30 Jul 2014 at 17:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fmitchell commentedThe patch failed for me as I think the key in the update statement was wrong. After I applied, there was still some odd logic that needed to happen to get it working that I had to clean up.
I'm attaching the patch of changes that I made. Please review and let me know if I'm still retaining the spirit of your original patch.
Comment #2
raystuart commentedThere is one bug that is fixed inside the patch on comment #1 that I needed, but applying the entire patch caused every event to want to have a required schedule date, which I'm not sure if it is the intention of the patch.
The fix that I needed was the event_comment moving inside the scheduled event check. I put it on a separate issue by itself here:
http://drupal.org/node/1836562#comment-6713248
Comment #4
das-peter commentedI've just pushed an overhauled approach to the 3.x branch.
Attached the patch with the changes I introduced - it's quite a bit.
I especially extended the form handling to be more seamless and avoid unnecessary state changes.
Further I had to extend the
on_exit_schedule()andon_exit_published()handling for nodes to ensure the publishing / unpublishing works properly.I'll post asap. a patch for Workbench Moderation that allows to use this new feature.
Comment #5
das-peter commentedPromised patch with the changes introduced in 7.x-3.x
Comment #6
das-peter commentedPatch for Workbench Moderation posted: #2130237-2: Integrate with State Flow Schedule / Revision Scheduler
I thing this deserves the status "Patch to be ported" now :)