Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Sep 2007 at 19:54 UTC
Updated:
12 Nov 2007 at 22:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
mdlueck commentedPossibly this problem / solution might help you as well:
http://drupal.org/node/165761
Clean URL's were not working with our hosting provider either. Maybe the same solution will fix your Clean URL's problem as well! ;-)
Comment #2
pasqualleYes, I can confirm that xampp default configuration (with default drupal settings) does not support Clean url's, however drupal identifies it as supported.
Comment #3
gábor hojtsy@mdlueck: Well, we are not to enable clean URL support here, but to investigate why it is reported to be working, while it is not.
The code checking the clean URLs is in system.js, and it looks for the following path on the server:
var url = location.pathname +"admin/settings/clean-urls";. Unfortunately it only looks whether HTTP 200 OK was returned, and does not check the contents printed. So if the sever responds with a HTTP 200 OK response, then the clean URL check thinks this should be OK.@gmasky and Pasqualle: can you please check manually, what your server returns when you try to access http://www.example.com/admin/settings/clean-urls (replace the domain name with your domain and path). Thanks.
Comment #4
gábor hojtsyCleaner title.
Comment #5
pasqualleI can't check it now, but I am pretty sure it returns the main screen of xampp. As any other drupal page (except the drupal's index page) shows the xampp main page, when clean-url is enabled.
note: I don't use domain name, so the path for the clean url is something like this http://localhost/drupal/admin/settings/clean-url
Comment #6
gábor hojtsyIt is quite bizarre to return a page with 200 OK, when there was actually no page found. Anyway, it seems to be better to also check for some actual result from the system clean URL check path, so we ensure Drupal returned something, not XAMPP or some server hack.
Comment #7
gábor hojtsyDoh, admin/settings/clean-urls is a real Drupal form page, so it is not ideal for JS side checking of some well defined short value. A separate checking path with a simple but well defined and distinguished result (eg. "Clean url check passed.") might be better.
Comment #8
gábor hojtsyComment #9
kkaefer commentedPatch changes the requsted URL to
/admin/settings/clean-urls/check. There is a new menu item which returns{ "status": true }as JSON. We split up the AJAX handler into success/error (instead of a generic complete like it has been before). If JSON is returned (and thus the request has been successful because we got JSON!), the success handler is called, if not, the error handler is invoked.Comment #10
kkaefer commentedComment #11
robloachThe patch unfortunately didn't do it......
Apache/2.2.4 (Win32), DAV/2, mod_ssl/2.2.4, OpenSSL/0.9.8e, mod_autoindex_color, PHP/5.2.2. mod_rewrite disabled.
Both the installer and /?q=admin/settings/clean-urls report "Your server has been successfully tested to support this feature.". When enabling Clean URLs, you get a page 404.
Comment #12
robloachInteresting. After some more investigation, I found that it started working after I cleared the local and server cache entirely and restarted the server. Would someone else be so kind to test it out? It's working here, but it would be good to get other test environments.
Comment #13
pasqualleOK, I tested the patch on the local xampp configuration, and now I see "Your system configuration does not currently support this feature. ..." at install and also on admin/settings/clean-urls page.
It seems good to me.
Comment #14
gábor hojtsyLooked at the code. I guess console.log(response); is leftover debug code, which should be removed. Apart from that this is IMHO RTBC, so once fixed, we can move back and commit as far as I see.
Comment #15
dries commented+ success: function (response) {can also become:
+ success: function () {Comment #16
pasqualleMade requested changes, and rerolled..
Tested on local xampp and also on ubuntu server. Works as expected.
Comment #17
robloachGreat work. Reviewed and both the installer and the Clean URLs settings page are reporting correctly now.
Comment #18
gábor hojtsyWow, I thought we had this in in the previous betas. Thanks for taking up the patch and moving forward. Committed.
Comment #19
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.