Just did a quick review of the admin of Panels & noticed a few missing labels on admin/structure/fieldable-panels-panes/manage/fieldable-panels-pane/display

Just running the WAVE Toolbar indicates that labels are missing on all of the elements in the group. Should be a pretty simple fix to ensure that the lapel is present & hidden or just properly associated.

CommentFileSizeAuthor
#4 Add-new-group-labels-1759680-4.patch2.27 KBmgifford

Comments

merlinofchaos’s picture

Status: Active » Closed (won't fix)

1) That path is part of the fieldable panels panes module, not Panels.
2) That path is actually handled by core's Field UI module, the same way that the manage display page for content types is. All Fieldable Panels Panes does is provide the menu entry and associated setup, and field UI renders the page from it. Any flaws it has should be shared by the manage display page for any (node) content type.

mgifford’s picture

Project: Panels » Fieldable Panels Panes (FPP)
Version: 7.x-3.3 » 7.x-1.x-dev
Status: Closed (won't fix) » Active

Sorry @merlinofchaos - I've really not done enough with Panels. That's changing though.

1) Switching this issue to Fieldable Panels Panes module.

2) It's not missing from the "Add new field" input fields in admin/structure/types/manage/blog/fields so pretty sure this is a bug introduced by Fieldable Panels Pane.

Thanks for pointing me in the right direction. Hopefully we'll be able to track this issue down quickly.

merlinofchaos’s picture

This is the entirety of the code in this module that handles those paths:

          'admin' => array(
            'path' => 'admin/structure/fieldable-panels-panes/manage/%fieldable_panels_panes_type',
            'bundle argument' => 4,
            'real path' => 'admin/structure/fieldable-panels-panes/manage/fieldable-panels-pane',
            'access arguments' => array('administer fieldable panels panes'),
          ),

(Note that in the latest release the path has changed slightly from earlier releases).

That's in fieldable_panels_panes_entity_info(). The field_ui module takes that data and makes tabs out of it and it fully handles those tabs. Why those act different I am not sure. It may be possible that there's some other data in hook_entity_info that we're missing, but if so I am unfamiliar with it.

The field_ui module takes that data and creates the tabs

mgifford’s picture

Project: Fieldable Panels Panes (FPP) » Field Group
StatusFileSize
new2.27 KB

Sorry about all the static here, but you've really helped to track this down. So many related modules, I really should have just stated with grep....

Anyways, found the problem. Provided a patch. Hopefully we can get it into a future release.

It boils down to the fields not being given titles.

Thanks again Merlin.

merlinofchaos’s picture

I'm glad I was able to help you track it down!

nils.destoop’s picture

Status: Active » Fixed

Thx for noticing this. The patch has been committed to dev.

mgifford’s picture

great!

Automatically closed -- issue fixed for 2 weeks with no activity.