As noted in #1114410: Replace hook_translation_info() with hook_entity_info(), that change broke my TMGMT tests and it looks like it already fails with the initial creation of the language-specific comment and it can be tracked down to that commit, so my guess is that it's a bug in ET.

CommentFileSizeAuthor
#9 et-comment-1760270-9.patch661 bytesplach
#7 et-comment-1760270-7.patch1.89 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

I suspect this is related to #1534674: Comment field language is completely broken.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

#1280546: Introduce a language selection widget for every entity should help with this, however comment translation cannot properly work until #1534674: Comment field language is completely broken is fixed.

slowflyer’s picture

slowflyer commented

tried to fix it. #1534674: Comment field language is completely broken

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Postponed

As per #2.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I've just tested again with an up to date entity_translation version and the tests almost* pass again, so it looks like maybe the referenced issue in #2 has fixed my problem. Can't really help with the core issue as I'm not actually using comment translation so I don't have a site with actual data or so.

* The only problem is an exception in translation.handler.inc: "Undefined index: #type". Easy fix, the comment form has a top level element without a #type, just an wrapper for other stuff. Will create an issue with a patch in a second. EDIT: Here we go: #1802452: Notice for form elements without a #type

So, from my point of view, this issue can be considered resolved once the core issue is resolved.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Anyone willing to have a look to the core issue and review/RTBC it?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new et-comment-1760270-7.patch1.89 KB

When the core issue is fixed we will probably need something like this.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Component: User interface » Base system
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed » Needs review
StatusFileSize
new et-comment-1760270-9.patch661 bytes

Updated patch: this still relies on #1534674: Comment field language is completely broken.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Postponed

Green

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed » Needs review

The core issue has been committed!

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Ok, I'll be bold and RTBC this: it is going in in a few days, last chance to test it :)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

#9: et-comment-1760270-9.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Latest 7.x and ET dev with the patch applied.

ENTITY SOURCE UI TESTS
Tests the user interface for entity translation sources.
275 passes, 0 fails, 0 exceptions, and 93 debug messages

Yay! :)

I did have to change the comment body field language from en to und when creating the comment initially, is that by design due to the changes? I assume it is, because everything was correctly extracted and translated afterwards...

Uploaded my patch that will enable it again to #1879250-1: Re-enable comment entity source translation tests.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

@Berdir:

I did have to change the comment body field language from en to und when creating the comment initially, is that by design due to the changes? I assume it is, because everything was correctly extracted and translated afterwards...

Yes, this is the intended behavior: now the entity language is used to generate field widgets, but initially an entity has LANGUAGE_NONE.

Committed and pushed #9, thanks for the quick feedback!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.

  • Commit 46bd148 on 7.x-1.x, factory, et-fc, revisions by plach: 
    Issue #1760270 by plach | Berdir: Fixed Comment translation broken?.

  • Commit 46bd148 on 7.x-1.x, factory, et-fc, revisions, workbench by plach: 
    Issue #1760270 by plach | Berdir: Fixed Comment translation broken?.