Token currently doesn't list the site mission as an available token. It would be helpful, for example, to have the site mission in outgoing invite messages (sent by the Invite module). Please review the attached patch.

CommentFileSizeAuthor
#7 token_mission_filterxssadmin.176036_1.patch1.2 KBchristefano
#4 token_mission_filterxssadmin.176036.patch1.12 KBChristefano-oldaccount
#3 token_mission_filterxssadmin.176036.patch1.12 KBChristefano-oldaccount
#1 token_mission.176036.patch12.57 KBChristefano-oldaccount
token_mission.patch1.11 KBChristefano-oldaccount

Comments

Christefano-oldaccount’s picture

Christefano-oldaccount commented
StatusFileSize
new token_mission.176036.patch12.57 KB

Rerolled for the current Token 5.x-dev.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

Your patch in #1 seems to be a little wrong (line ending problem?).

In general I think this is a good idea, but it probably needs to be sent through a check function. phptemplate.engine sends it through filter_xss_admin - see the phptemplate_page function.

Christefano-oldaccount’s picture

Christefano-oldaccount commented
StatusFileSize
new token_mission_filterxssadmin.176036.patch1.12 KB

Yikes, just goes to show I should review my own patches. I think one of the files read by diff was read as a binary.

Here's another one which includes the use of filter_xss_admin(). Great suggestion.

Christefano-oldaccount’s picture

Christefano-oldaccount commented
Status: Needs work » Needs review
StatusFileSize
new token_mission_filterxssadmin.176036.patch1.12 KB

Oops, let's try that again.

christefano’s picture

christefano commented

Has anyone had a chance to review this yet?

christefano’s picture

christefano commented

Still applies cleanly against 5.x-1.11.

christefano’s picture

christefano commented
StatusFileSize
new token_mission_filterxssadmin.176036_1.patch1.2 KB

Rerolled for the current 5.x-dev.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Thanks, christefano for your persistance on this issue. I've applied it to both 6.x http://drupal.org/cvs?commit=127513 and 5.x http://drupal.org/cvs?commit=127512

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.