I've updated to the CVS version (thanks!) and now the T&C is displayed properly and allows users to accept the new T&C. However, there is still a problem. If the user has already accepted the T&C, it's displayed and the checkbox is checked and disabled. This means you can't uncheck it. However, I think that some browsers make the checkbox return false when it's disabled because I can no longer change my profile, it tells me I have to accept the T&C.

I fixed it by commenting out line 95. This means the checkbox never disables, but it seems to work fine.

CommentFileSizeAuthor
#4 legal.patch463 byteskm

Comments

robert castelo’s picture

robert castelo commented

If the user has already accepted the T&C, it's displayed and the checkbox is checked and disabled. This means you can't uncheck it.

That's by design - we don't want users to un-accept T&C.

I think that some browsers make the checkbox return false when it's disabled because I can no longer change my profile, it tells me I have to accept the T&C

Which browser did you have this problem on?

binford2k’s picture

binford2k commented

Mozilla 1.7.5

km’s picture

km commented

... and Safari 1.2.4

km’s picture

km commented
StatusFileSize
new legal.patch463 bytes

form_checkbox() sets a hidden value of zero. See the attached patch to add a hidden value of 1.

robert castelo’s picture

robert castelo commented

Fixed in latest version (legal.module 1.7)

If T&C have already been accepted legal.module doesn't try to validate or enter data to database.

robert castelo’s picture

robert castelo commented