Many Aegir updates to the hosting configuration first require that the "Verify" task is run before the change takes effect (for example: a site alias change).

This is not obvious at first.

Suggest that the site node edit message be adapted from:

"Site XYZ.com has been updated."

To:

"Site XYZ.com has been updated. Any changes may not take effect until after the verify task has been run."

Comments

helmo’s picture

The verify task is triggered automatically right?

Your suggestion might leave a user wondering whether they should themselves trigger a verify task.

What about: "Site XYZ.com has been updated. A Verify task has been created to process any changes."

ergonlogic’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Active » Postponed (maintainer needs more info)
ken hawkins’s picture

Status: Postponed (maintainer needs more info) » Active

Had forgotten about this issue. The suggestion by Helmo in #1 sounds like an improvement to me.

ergonlogic’s picture

This isn't just a string change, as this message is generated by the node module in core. Also, it applies to platform and server node save too. I'm inclined to add this message to all 3: "Any changes will take effect once the scheduled Verify task has been processed."

ergonlogic’s picture

Project: Hostmaster (Aegir) » Hosting
Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Active » Fixed

Fixed in 4d1f29b

ergonlogic’s picture

I reverted the above fix, since it was causing the message to be displayed much more often than it should have. New fix in 6d06b8f.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4d1f29b on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Issue #1761932 by Ken Hawkins, helmo, ergonlogic: Explain that updates...
  • Commit 6d06b8f on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Issue #1761932 by Ken Hawkins, helmo, ergonlogic: (fixed) Explain that...
  • Commit 869c29f on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Revert "Issue #1761932 by Ken Hawkins, helmo, ergonlogic: Explain that...

  • Commit 4d1f29b on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Issue #1761932 by Ken Hawkins, helmo, ergonlogic: Explain that updates...
  • Commit 6d06b8f on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Issue #1761932 by Ken Hawkins, helmo, ergonlogic: (fixed) Explain that...
  • Commit 869c29f on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic:
    Revert "Issue #1761932 by Ken Hawkins, helmo, ergonlogic: Explain that...
jon pugh’s picture

Issue summary: View changes

This language doesn't make sense if installing a site or creating a new platform.

I've committed e97ce4 to add messaging like so:

Creation:

Verify task has been queued for server SERVER_NAME. It will be available once the task is completed.

Verify task has been queued for platform PLATFORM_NAME. It will be available once the task is completed.

Install task has been queued for site SITE_NAME. It will be available once the task is completed.

Editing:

Verify task has been queued for platform SERVER_NAME. Changes will be applied once the task is completed.

Verify task has been queued for platform PLATFORM_NAME. Changes will be applied once the task is completed.

Verify task has been queued for site SITE_NAME. Changes will be applied once the task is completed.

After I did this, I couldn't help myself. I improved the Task schedule message as well. This drupal_set_message() call shouldn't be in hosting_add_task(), and it shouldn't be called if the hosting task queue is disabled.

See fef1ca

So now, only if you are actually using the queue, installing a site looks like this:

  • Install task has been queued for site drupal.org. It will be available once the task is completed.
  • Task is scheduled to start in approximately 43 sec.
  • Site drupal.org has been created.
jon pugh’s picture

I still think we should get rid of the drupal core "@type %title has been created." message. It's not helpful here.