Upgrade to jQuery 1.2.1

Why not test Drupal stuff, to ensure that everything still works? We might have specific code which is broken due to bug fixes.

Drupal functionality will need to be checked, but I also think it's important to push for this upgrade for the final D6 release since there are a number of cross-browser compatibility jQuery bugs in 1.2 that are fixed in this 1.2.1 release.

A full report of these can be found here: http://dev.jquery.com/report/17

That's fine. There won't be a new release of Drupal by tomorrow. It still needs to not break HEAD when applied.

To test, report the success of attempting each of the JavaScript tests at http://groups.drupal.org/node/5974, along with what browser/OS/versions you're using.

That's fine. There won't be a new release of Drupal by tomorrow. It still needs to not break HEAD when applied.

To test, report the success of attempting each of the JavaScript tests at http://groups.drupal.org/node/5974, along with what browser/OS/versions you're using.

Konqueror and Firefox, Kubuntu Linux.

Install: OK
Collapsing fieldsets: OK
Node teaser split: Firefox OK, Konqueror it does not populate the teaser field. Merging again means that the teaser data is lost.
Table header scroll: OK
Book module outliner: OK
Password checker: OK
Checkbox selet-all: OK

Looks like everything works except for the teaser splitter in Konqueror, which I believe was broken before, too. However, I do not believe that is acceptable. If the solution is to disable the node splitter in Konqueror I am OK with that, but right now the behavior is data loss, and that is not acceptable.

Firefox 2.0.0.7/WinXP and IE7/WinXP

Install: OK
Collapsing fieldsets: OK
Node teaser split: OK
Table header scroll: Firefox: OK, IE7: Table header does not move
Book module outliner: OK
Password checker: OK
Checkbox select-all: OK

Sorry, the table header problem is not related to this patch : it occurs with the current Drupal 6-dev too.

Okay, I can verify this works for Firefox/Camino/Safari on Mac.
We need someone to test this on Konqueror and carry our little baby into core..

So, who's up to the job of testing this on Konqueror and setting this RTBC (or not)?

I'm still getting the same data loss bug in Konqueror. :-(

If something was broken before, is it up to this patch to fix it? I'm downloading KDE at the moment to try to fix the problem, but it feels like we should create a separate issue for Konquerer, since this upgrade doesn't cause the breakage. I'd like to get the 1.2.1 version in as soon as possible, since it also fixes the AHAH patch when clean urls are disabled: http://drupal.org/node/157752#comment-310714

In that case #2 could do with being set to RTBC, and #10 should be split into a new issue I think.

I agree two patches would be sensible since this one hasn't introduced any new bugs, but fixes the AHAH one.

I will defer to Dries/Gabor on that. If this one goes in as is, I'll open a new critical issue for the Konqueror splitter bug.

fwiw, the Konqueror bug was present in the original teaser splitter patch as noted byKbahey in the issue. It went in without further comment there.

OK then...

Here's a new issue for the teaser splitter: http://drupal.org/node/178818. We'll need to get it fixed before the D6 release.

As for this issue, let's apply #2 and bask in the 1.2.1 goodness.

OK, thanks for testing. I know the teaser splitter was broken in Konqueror, so fixing that is not a stopper for this patch. Applied #2 and committed. Thanks!

Just bumping this thread to alert everyone to that jQuery 1.2.2 has been released, and a patch has been rolled that could use some testing: http://drupal.org/node/210131