Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.theme_get_setting() in theme.inc contains some comments which seem to advocate hacking core files.
I suggest removing these two lines:
// To add new global settings, add their default values below, and then
// add form elements to system_theme_settings() in system.admin.inc.
There are modules in contrib (touch_icons, noggin) which extend themesettings variables, and they do it through hook_form_alter().
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | theme_get_setting-comments-1762572-1.patch | 603 bytes | andrewmacpherson |
Comments
Comment #1
andrewmacpherson commentedpatch for D8
Comment #2
andrewmacpherson commentedComment #3
jhodgdonHm. I think this is a comment for core developers, not an inducement for hacking core. Moving to different component for comment, as this is not purely a docs issue.
Comment #4
star-szrI believe the theme settings system has changed thoroughly enough for this to no longer apply, bumping to D7 at least.
Comment #5
jhodgdonI do not actually agree that these comments are advocating hacking core. I think they are reminding people who need to make a Core patch to add a new setting, how they would go about doing this. I do not think we should remove this comment.
We could reword it but... at this point in 7.x probably not worth it.
Feel free to reopen and propose a rewording patch if you disagree, but I don't think I'd commit the removal patch.
Comment #6
star-szrYup, that makes sense to me too. Thanks @jhodgdon.