Making a fresh install of Drupal 6 from CVS and going straight to admin/build/themes, before doing anything else, I get

notice: Undefined index: version in /srv/http/localhost/htdocs/drupal6/modules/system/system.admin.inc on line 2051.

It doesn't seem to affect anything, but doesn't look too nice. :)

CommentFileSizeAuthor
#3 system-admin.patch529 byteswmostrey

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

This is still an issue, only now it's on line 2064.

To reproduce, add a folder under sites/all/themes called 'example', and place a file called 'example.info' in there with the following contents:

name = Example
description = Sample description.
core = 6.x

(this simulates downloading a theme from CVS that doesn't have the version = ... string populated.)

patchnewbie’s picture

patchnewbie commented
Assigned: Unassigned » patchnewbie

This is probably a good patch for someone new to core development to work on.

wmostrey’s picture

wmostrey commented
Status: Active » Needs review
StatusFileSize
new system-admin.patch529 bytes

This looks like a clean solution.

aufumy’s picture

aufumy commented
Status: Needs review » Reviewed & tested by the community

tested patch and it works fine (after removing '-old' in system.admin-old.inc)

Thanks
Audrey

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks Wim.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.