I noticed that the Drupal 7 CHANGELOG.txt has entries copied over from Drupal 6, but those aren't quite up to date anymore (and also, at one point the section header for "Drupal 6.23-dev" seems to have gotten copied in there, which doesn't make any sense).

Here's a patch that will fix that. Presumably, this is something we have to do periodically (and also for Drupal 8), assuming we want to keep all the CHANGELOG.txt entries merged correctly going forward...

CommentFileSizeAuthor
#15 Screenshot 2021-05-06 at 2.09.01 PM.png20.59 KBbhumikavarshney
#15 Screenshot 2021-05-06 at 2.08.56 PM.png20.69 KBbhumikavarshney
#14 changelog-txt-update-1762708-14-2.patch4.89 KBmulambo
#14 changelog-txt-update-1762708-14-1.patch2.72 KBmulambo
#1 changelog-txt-update-1762708-1.patch1.35 KBDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Component: user interface text » documentation
Status: Active » Needs review
StatusFileSize
new changelog-txt-update-1762708-1.patch1.35 KB

Here's the patch for Drupal 7. And somehow I posted this issue in the wrong component...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

That looks OK... Does it need to get put into the 8.x branch too? If so, by usual policy, we should start there and then patch 7.x.

Alternatively, I wonder if we need all the 4.x, 5.x, 6.x, etc. versions in the 7.x file at all?

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.0.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs backport to D7

I guess it's time to get this into Drupal 8.

Could be a simple patch, except for two questions (somewhat related to jhodgdon's comment above):

  1. Do we really copy all older versions over? I.e. Drupal 6.37 was released after Drupal 7.0 was, so should it still appear in CHANGELOG.txt but lower down than Drupal 7.0 (with the dates out of order)? I think probably yes... but maybe not.
  2. For each version (e.g. 7.40), do we really copy the whole thing over to Drupal 8's CHANGELOG.txt? In Drupal 7 we started adding a fair amount of detail to CHANGELOG.txt for each point release, so that people could see a note about anything that had a chance of causing a problem with their existing sites. But that kind of detail isn't necessarily needed going forward. So I could imagine copying a shorter version over for each that just contains the true highlights only.
David_Rothstein’s picture

David_Rothstein commented

Do we really copy all older versions over? I.e. Drupal 6.37 was released after Drupal 7.0 was, so should it still appear in CHANGELOG.txt but lower down than Drupal 7.0 (with the dates out of order)? I think probably yes... but maybe not.

Thinking about it more I'm actually leaning towards not. Everything added in those later releases should already be in the next version of Drupal anyway (unless it's not applicable). For example, Drupal 6.37 was for SA-CORE-2015-003, but so was Drupal 7.39 - so we'd just be repeating the same thing twice in the CHANGELOG.txt.

This also means we don't have to keep copying new CHANGELOG.txt entries forward ad infinitum (which probably wouldn't happen anyway).

So if we do it that way, we would just need to copy Drupal 6 entries through Drupal 6.20 and Drupal 7 entries through Drupal 7.41 to the Drupal 8 CHANGELOG.txt, and not add any others.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Version: 8.9.x-dev » 7.x-dev
Issue tags: -Needs backport to D7

CHANGELOG.txt has been modified a few times since this issue was create. The most relevant is #2647824: [policy and patch] Determine what should go in CHANGELOG.txt for 8.x core releases where the was decided to include link to pages with relevant information.

This still applies to the Drupal 7 file, though.

mulambo’s picture

mulambo commented
Status: Needs work » Needs review
StatusFileSize
new changelog-txt-update-1762708-14-1.patch2.72 KB
new changelog-txt-update-1762708-14-2.patch4.89 KB

There shouldn't be any harm done by adding patch notes from previous versions (6.x), like it was before 6.23. Since Drupal 8 doesn't include patch notes in changelog and Drupal 6 reached EOL this would be limited to one time only action in Drupal 7.

There are 2 aspects:
1) We include patch notes untill final release 6.38 (patch changelog-txt-update-1762708-14-1.patch).
2) We include patch notes from Drupal 6 LTS 6.52 (patch changelog-txt-update-1762708-14-2.patch)

bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new Screenshot 2021-05-06 at 2.08.56 PM.png20.69 KB
new Screenshot 2021-05-06 at 2.09.01 PM.png20.59 KB

Hi @Mulambo ,
Both the patch applies cleanly and i have tested this for Drupal 7.
Thanks

poker10’s picture

poker10 commented
Status: Needs review » Closed (won't fix)

Thanks for reporting and working on this.

I do not think this is worth doing - D10 CHANGELOG.txt was changed and it does not contain such information anymore, see: https://api.drupal.org/api/drupal/core%21CHANGELOG.txt/10 (and #2647824: [policy and patch] Determine what should go in CHANGELOG.txt for 8.x core releases). The file never contained information about all D7 releases. Agree with David comment #4, that adding all D6 releases would duplicate fair amount of fixes, as most of them were backported from D7 to D6 in later phases.

We will continue with adding short changelog entries on each D7 release until the D7 EOL. But regarding the D6 entries, I think the best approach is to close this as Won't fix.