I updated eva to 1.2 and got a series of Undefined index notices
"Notice: Undefined index: exposed form in eva_field_extra_fields() (line 32 of /sites/all/modules/eva/eva.module)."

A patch is attached.

CommentFileSizeAuthor
eva-undefined-index.patch667 bytesjzornig

Comments

mkadin’s picture

mkadin commented
Status: Needs review » Needs work

isset($['exposed form']) will return true when $['exposed form'] = false, which isn't the desired behavior.

The list of views pulled out of the cache in eva_get_views() doesn't have some stuff that it will always have after the update. I think we just need to clear that cache with an update hook, but that theory needs to be tested.

mkadin’s picture

mkadin commented

did this occur just during the update process? Or does it show up on eva page? I'm unable to reproduce.

jzornig’s picture

jzornig commented

I only saw it on the update.

moonray’s picture

moonray commented

I get it when clearing cache.
EDIT: Seems to be only the first time I cleared cache after updating. After that the issue is no more.

mkadin’s picture

mkadin commented
Status: Needs work » Fixed

I've used empty() to fix this problem - should be all set for any sites that still need to upgrade.

Thanks for submitting this. It's not in the dev branch and will be a part of the next release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.