HTML / markup compliance errors (ampersands not encoded properly)

Thanks for the report. I've confirmed this problem. While in development I struggled with trying to get all the characters to encode properly. The situation is messy because the query string is encoded, but then inside of that, the redirect location has to be url encoded. The combination of how to get these two different encodings working at the same time has eluded me.

Moving to minor since this doesn't affect the functionality of the module.

I was about to report the issue myself until I found it was already reported. Two ampersands http://screencast.com/t/psVeRJ9tiikU

While functionality is fine remember that standards should be a starting point, not an afterthrought. We don't want these kinds of habits brewing because it is the same kind of slippery slope with IE in the early days that made our lives very difficult for the longest time.

While functionality is fine remember that standards should be a starting point, not an afterthrought.

If it makes you feel any better, I've spent at least two attempts of an hour each trying to get that URL to pass validation. Like I said in #1, there's multiple layers of encoding happening here. We already encode the URL twice, but apparently a 3rd time is needed somewhere. It's not an afterthought, it's a matter of the inability to get the URL encoded correctly and still have the module functional. Between proper encoding and not have a module at all, I'm sure everyone would prefer to have the module.

I'm sure this is a simple fix, but it's figuring out what that simple fix is that is the challenge. I'd be more than happy to review/commit a patch from anyone that can fix this problem.

Hi, I've made simple fix for this problem.
In fboauth.module file on line 423 just after the

function theme_fboauth_action__connect($variables) {
  $action = $variables['action'];
  $link = $variables['properties'];
  $url = url($link['href'], array('query' => $link['query']));

I've put simple string replace ;)

$url = preg_replace( "/&(?!amp;)/", "&",  $url  );