In #1129512: Make Google maps geolocation widget compatible with Geofield, I'm working to let the widget be used in Geofield which makes Geolocation a non-required module.

My preference is to move Google Maps geolocation widget into its own module, but let's discuss which is the way to go.

CommentFileSizeAuthor
#1 1764130-1-am.patch911 bytesjherencia
#1 1764130-1.patch514 bytesjherencia

Comments

jherencia’s picture

jherencia commented
Status: Needs work » Needs review
StatusFileSize
new 1764130-1.patch514 bytes
new 1764130-1-am.patch911 bytes

And here is the patch if we decide to remove the dependency.

Sinovchi’s picture

Sinovchi commented

The provided patch #1 is working.

jherencia’s picture

jherencia commented

Any comments about this?

gmclelland’s picture

gmclelland commented

Didn't realize it could work without the geolocation.module. +1 for removing the dependency. So far my only need for using this module is for it's geofield module integration which is great btw.

IMO, that geofield integration should be advertised on this module's project page with a screenshot showing the google maps input widget.

  • derjochenmeyer committed 85f3b6c on 7.x-1.x 
    Issue #1764130 by jherencia: Added Remove Geolocation dependency from...
derjochenmeyer’s picture

derjochenmeyer commented
Issue summary: View changes
Status: Needs review » Closed (fixed)

Commited. Dependency removed. Late but thanks.