Well, the title its self-explanatory, but for reference, this is part of my attempt to make Google Maps geolocation module work with Geofield.

For reference the widget it's being discusses in issue #1129512: Make Google maps geolocation widget compatible with Geofield.

CommentFileSizeAuthor
#6 1764138-6-am.patch3.63 KBjherencia
#6 1764138-6.patch3.21 KBjherencia
#6 interdiff.txt733 bytesjherencia
#1 1764138-1-am.patch3.47 KBjherencia
#1 1764138-1.patch3.06 KBjherencia

Comments

jherencia’s picture

jherencia commented
StatusFileSize
new 1764138-1.patch3.06 KB
new 1764138-1-am.patch3.47 KB
jherencia’s picture

jherencia commented

For the record, Google Maps geolocation formatter is broken in 7.x-1.x-dev version. I've reopened the issue #1558580: HTTPS and SSL URL paths without the protocol which broke it and I've added the fix.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Needs work

We should add a comment here, similar to #1129512: Make Google maps geolocation widget compatible with Geofield

mgifford’s picture

mgifford
he/him
Primary language English
commented

Do you mean this comment:

+  // To make this widget compatible with geofiled we need to rename the keys for
+  // longitude. Geofield uses "lon" while Geolocation Field uses "lng".
derjochenmeyer’s picture

derjochenmeyer commented

yep maybe just:

+  // To make this widget compatible with geofiled we need to rename the keys for
+  // longitude. Geofield uses "lon" while Geolocation Field uses "lng".
+  $lng_key = ($field['type'] == 'geofield') ? 'lon' : 'lng';
jherencia’s picture

jherencia commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt733 bytes
new 1764138-6.patch3.21 KB
new 1764138-6-am.patch3.63 KB

Added the comment and rerolled to latest 7.x-1.x.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Fixed

Thanks. Committed. Should be in 7.x-1.x-dev in a few hours.
Strange that the git am commits don't appear in http://drupal.org/node/241478/commits

jherencia’s picture

jherencia commented

Great :).

About the commits, they appear, but they have the date I created the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.