Hidden profile fields can not be required or registration

viadimezzo - September 18, 2007 - 01:24
Project:Drupal
Version:5.x-dev
Component:profile.module
Category:bug report
Priority:normal
Assigned:chx
Status:closed
Description

I created four profile-fields under the same category. On creation of the fields, I set the options "Visibility = Hidden", "The user must enter a value. " and "Visible in user registration form." on each field to be true. Neither on registration nor on visiting my profile as admin (there is no category tab) those additional fields are visible. The fields are created in the datebase-table "profile_fields".

Attached, you will find some screenshots.

AttachmentSize
5_0.jpg178.38 KB

#1

chx - September 30, 2007 - 18:22
Title:No display of additional profile-fields» Hidden profile fields can not be required or registration
Assigned to:viadimezzo» chx
Status:active» patch (code needs review)
AttachmentSize
hidden_profile-176503-1.patch793 bytes

#2

Gábor Hojtsy - October 1, 2007 - 11:03

Patch looks nice, although there is a dot missing from the end of the first message. (There was a time when we did not use to have dots at the end of messages, I wonder what the current practice is). Also I would write "cannot" instead of "can not", but this should be checked by a native English speaker, I guess.

#3

bennybobw - October 4, 2007 - 20:47
Status:patch (code needs review)» patch (reviewed & tested by the community)

I was looking through and saw a lot of dots on the ends of messages, so I added one to the first message. I changed can not to cannot and the second message reads

A hidden field cannot be set to visible on the user registration form.

instead of "set to be visible."

Here's the patch, should be ready to go.

AttachmentSize
hidden_profile-2.patch982 bytes

#4

Gábor Hojtsy - October 5, 2007 - 13:27
Version:6.x-dev» 5.x-dev
Status:patch (reviewed & tested by the community)» patch (to be ported)

Thanks, committed. I guess this needs to be backported.

#5

Bart Jansens - January 13, 2008 - 11:21
Status:patch (to be ported)» patch (code needs review)

backported.

AttachmentSize
20080113.profile-hidden-fields.patch963 bytes

#6

drumm - February 11, 2008 - 05:36
Status:patch (code needs review)» fixed

Committed to 5.x.

#7

Anonymous (not verified) - February 25, 2008 - 05:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.