short page

I just wanted to confirm this bug and point out that this is definitely a show stopper. The theme is amazing but this bug makes it quite unusable, at least for people who have a good number of side bars. I hope to see this fixed soon as I absolutely love the theme and can't wait to use it.

Nick

Have implemented a workaround to that problem you mentioned..i.e. with the short page issue...I'm not an expert on CSS so, I'm not sure which class needs to be changed in the stylesheet..but, I thought I'd share the following workaround in case it is of any use.

these steps push the page footer down to appear after the last blocks/elements in the side-bar content..so the page looks more complete when there is not much content in the main node and you get that "short page" effect you mentioned.

1. make a backup copy of your page.tpl.php file and open the file in notepad or a suitable text editor. (you will find the page.tpl.php layout file under the /themes/friendselectric/ folder)

2. Scroll down to the bottom of the file where you find the FOOTER statement. you just need to move the footer down a few lines. (The theme developer didn't comment the file in detail, so it's difficult for me to describe where exactly you need to move the footer statement to. Might be easier to replace the last section of the page.tpl.php file with the following.)

</div>
 <?php if ($sidebar_right != ""): ?>
 <div class="sidebar" id="sidebar-right">
   <?php
     // Mark first block title
     list($a, $b) = explode('<h2>', $sidebar_right, 2);
     print $a . '<h2 class="first">' . $b;
   ?>
 </div>
 <?php endif; ?> 
 
 <span class="clear"></span>
 
</div>
<?php if ($footer_message): ?><div id="footer" class="footer-<?php print $layout; ?>"><p><?php print $footer_message; ?></p></div><?php endif; ?>
</div></div></div></div></div>
</div></div></div>
<?php print $closure;?>
</div></div></div>
<div id="end" class="end-<?php print $layout; ?>"><div class="ew1"><div class="ew2"></div></div>
</body>
</html>

Hope that helps

Dub

P.S. Great Theme!

but what happens with the side content is shorter than the nodes. Instead of using an image, I'm just using a background color on the left side bar. If I set the color to "100%" it goes only down as far as the sidebar content in IE. If I set to a long number, like 1500px it stretches that far no matter how much content in on the side or the middle. Will this patch get both side and middle to line up?

i found a workaround that seems to work well in mozilla and IE, but i'm not experienced enough to say whether its a bad practice or not. either way, here it is.

in the' /drupalinstallfolder/themese/friendselectric/' folder find the stylesheet called style.css

change the folowing section

#main {
_float: right;
margin: 0px;
_width: auto;
height: autopx;
}

to

#main {
_float: right;
margin: 0px;
_width: auto;
height: 800px;
}

*you could change the height to any number you like.

my first post and im glad its providing help as opposed to asking a question. love drupal and this theme is great!

hope it helps someone.
cheers

Thanks for posting the static length fix, but the theme is meant to be dynamic, and it will look wierd when the sidebar is extra long or too short as content on each page/node will most likely not fit one static length.

It would be nice to get this fixed. If the author could explain to me what needs to be fixed, or tell me where to look I would be willing to at least try and find the error.

One thing I did notice is that on Drupal.org's theme garden the short page error is non-existent. Perhaps that is because they are using both a left and a right sidebar.

I have tried various ways to fix this, and none works satisfactorily. The normal way to fix this (to float the main content) causes Mozilla to stretch all the fieldsets inside to insane width. Other hacks don't work on IE or Opera.

Using one-pixel overlaps prevents clears from working in the main content (this is a bug with 90% of the "ready-made" CSS templates out there).

It's tricky.

This seems to be a common complaint with this theme, but it's an easy fix.

With an out-of-the-box installation of this theme,

//-------OPEN-------//
page.tpl.php

//-------FIND-------//
if ($help != ""):

print $help;

endif;

if ($messages != ""):

endif;

print phptemplate_wrap_content($content)

if ($footer_message):

endif;

//-----ADD AFTER-----//

//-----SAVE & UPLOAD-----//

Voila! The left column background will now stretch down to meet as much sidebar content as is delivered.

This seems to be a common complaint with this theme, but it's an easy fix.

With an out-of-the-box installation of this theme,

//-------OPEN-------//
page.tpl.php

//-------FIND-------//

   <?php if ($help != ""): ?>
      <p id="help"><?php print $help; ?></p>
    <?php endif; ?>
        
    <?php if ($messages != ""): ?>
      <div id="message"><?php print $messages; ?></div>
    <?php endif; ?>
        
    <?php print phptemplate_wrap_content($content) ?>
 
    <?php if ($footer_message): ?><div id="footer" class="footer-<?php print $layout; ?>"><p><?php print $footer_message; ?></p></div><?php endif; ?>
  </div></div>
 </div>

//-----ADD AFTER-----//

  <!--added to extend left column background-->
  <span class="clear"></span>

//-----SAVE & UPLOAD-----//

Voila! The left column background will now stretch down to meet as much sidebar content as is delivered.

This should be now fixed in 4.6 and HEAD.

I used a different fix: when I tried adding clears, it didn't work because the left sidebar had a negative right margin equal to its width. The common trick is to set the right margin 1 pixel less than its width, so it can still clear floats. But that meant that there were problems when clearing items inside the main content too: the content would drop down below the sidebar if there was a clear inside it.

The method now uses a correct, CSS2 specific method for those browsers that support it. It works for me in Firefox and Opera, while IE6's broken float model actually solves the bug on its own, without using the extra rules (IE doesn't understand them).