Closed (fixed)
Project:
Entity Translation
Version:
7.x-1.x-dev
Component:
Base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Sep 2012 at 21:24 UTC
Updated:
12 Jun 2014 at 22:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bforchhammer commentedHm, isn't this already covered by the "edit translation shared fields" permission?
Comment #2
plachNot exactly, I might be allowed to edit shared values but find more usable to have them only when editing the original values.
Comment #3
bforchhammer commentedAttached patch adds an option to the ET settings page for hiding shared fields on translation forms.
Comment #4
plachThanks!
Can we make this a per-bundle setting? I'd like to do the same also for the options above, but that's another issue.
Let's keep the $access variable and initialize it through the new method outside the loop to save some invocation. Also: there's a space before the trailing semicolon.
Comment #5
plachComment #6
bforchhammer commentedMade is a per-bundle setting and fixed the
$accessissue.Comment #7
plachOverall the patch looked good. I tested it with users and I found a couple of issues. The attached patch fixes them.
Comment #8
plachOn the next reroll, if we want to keep this, we should also hide shared labels by default.
Comment #9
plachFor consistency I reverted the user entity info default added in #7. This patch ensures that all the translatabilty clues are added only after creating an entity, which allows us to determine whether it is actually translated or not. It fixes also a notice.
Comment #10
plachCommitted #9 to fix those annoying bugs. Feel free to mark fixed if no follow-up is needed.
Comment #11
plachWe will test coverage also for this.
Comment #12
plachI'll call this fixed. Feel free to reopen if needed.
Comment #13
bforchhammer commentedJust tested it and it seems fine. Thanks!