Follow-up to:
- #1324618: Implement automated config saving for simple settings forms
- #1696224: Remove system_settings_form()
- #1653026: [META] Use properly typed values in module configuration
Given:
system.performance.yml config object containing (among other keys):cache:
page:
enabled: '0'
$form['caching']['cache'] = array(
'#type' => 'checkbox',
'#title' => t('Use internal page cache'),
'#description' => t("If a reverse proxy cache isn't available, use Drupal's internal cache system to store cached pages."),
'#default_value' => $config->get('cache.page.use_internal'),
);
Then:
- $form['caching']['cache'] = array(
+ $form['caching']['cache.page.enabled'] = array(
'#type' => 'checkbox',
'#title' => t('Use internal page cache'),
'#default_value' => $config->get('cache.page.enabled'),
'#weight' => -2,
);
public function submitForm(array &$form, array &$form_state) {
[...]
$this->config('system.performance')
- ->set('cache.page.use_internal', $form_state['values']['cache'])
+ ->set('cache.page.use_internal', $form_state['values']['cache.page.enabled'])
->set('cache.page.max_age', $form_state['values']['page_cache_maximum_age'])
enabled: '0'
Comments
Comment #1
mtiftThe casting part of the original report is handled, but the form array part is not, so I updated the summary.
And just to clarify the tags:
beta target == "we'd like to have this in some beta"
beta deadline == "if we don't do this by beta1 we don't do it in 8.0.x"
Comment #2
catchAdmin configuration form array structures aren't a critical API, so this can still be beta target or possibly even minor version target.
Comment #3
xjmComment #16
catchWe did this (and related issues) instead: #3398982: ConfigFormBase + validation constraints: support non-1:1 form element-to-config property mapping again.