There are just 2 options_validate() left with incompatible signatures. See attached.

Thank you.
Alexis Wilke

CommentFileSizeAuthor
view-3.x-form_reference_options_validate.patch962 bytesAlexisWilke

Comments

Status: Needs review » Needs work

The last submitted patch, view-3.x-form_reference_options_validate.patch, failed testing.

AlexisWilke’s picture

AlexisWilke commented

Reference #653628: Declaration of views_handler_filter_many_to_one::init() should be compatible with that of views_handler_filter::init()

AlexisWilke’s picture

AlexisWilke commented
Status: Needs work » Active

Marking as active as there are no tests for this version and needs work may not be looked at.

dawehner’s picture

dawehner
Primary language German
commented

You just have to create a patch which applied with patch -p1, for example use git for that instead of manually use the diff command :)

AlexisWilke’s picture

AlexisWilke commented

Yes, but even the one that I submitted and applies (patches right) does not show as a success because the system cannot find a test suitable to run against. Anyway, the test would probably be "broken" (or not sufficient) since the patch is expected to be fixing something that's not correct. 8-)

dawehner’s picture

dawehner
Primary language German
commented

Well there is no test, but at least this shows whether the patch applies or not ...
Changing the signature (even it might fixes some notices) can cause additional notices on all sub-handlers so i would vote to not change the one on the base handler.

AlexisWilke’s picture

AlexisWilke commented

In PHP all the signatures of a function need to be exactly the same in all the classes. There isn't a choice here.

Let me know if you want me to upload a new patch that applies. It's just missing the a/ and b/ folder names that are now used with git.

chris matthews’s picture

chris matthews commented
Issue summary: View changes
Status: Active » Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue