Posted by vasike on September 3, 2012 at 2:35pm
9 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | install system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
imho there should be a way to change the constants defined for the system requirements
as 'DRUPAL_MINIMUM_PHP' or 'DRUPAL_MINIMUM_PHP_MEMORY_LIMIT'.
there could be some complex install profiles that requires "more power" from the system.
for example there's a Commerce Kickstart issue about this : #1763632: The install needs to check Kickstart requirements before starting.
Comments
#1
here is a patch that allows thatbad approach
are there other system requirements constants that could be changed?
#2
here is a new approach for changing the php system requirements.
it uses the install_profile_info definition.
so what it's needed it's to specify new values in the info file of the profile
#3
The last submitted patch, allow_change_system-requirements-1772316-2.patch, failed testing.
#4
rebuilt the patch, i hope it's the right one
#5
and here is the patch for Drupal 8
#6
#7
Looks like some D7 install profiles have been using #4 and it no longer applies to HEAD as of 7.22. :(
Added tags Needs reroll but there's no way to specify thats a D7 reroll since this is also being tracked as an 8.x issue - sorry.
#8
#5: allow_change_system-requirements-1772316-5.patch queued for re-testing.
#9
The last submitted patch, allow_change_system-requirements-1772316-5.patch, failed testing.
#10
We need to get this into D8 before we worry about D7. I requeued the patch in #5 (I doubt it'll pass - last test run was in September). If that fails, lets reroll that, get it committed, then deal with D7.
#11
Ah, cross posted with the bot. So yeah, need to reroll that patch.
#12
Let's give this a try. I moved around your new block of code in system.install so that we're not calling drupal_get_profile() multiple times - now it's just called once at the beginning of the function and used throughout.
#13
#14
The last submitted patch, 1772316_12-allow-profiles-to-override-php-requirements.patch, failed testing.
#15
Made system.install default to DRUPAL_MINIMUM_PHP_MEMORY_LIMIT if it's not set in the profile (this is what caused the previous patch to fail).
#16
Patch failed to attach to last post.
#17
I'm not sure about "Drupal requires at least PHP %version.", as this is not true if the profile uses a different max version than Drupal. Drupal with [name of profile] requires this version, yes. Also the same issue in the message about the memory limit.