[D7] twitter_cards

Welcome,

Please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxadamelleston1736082git

And you need to set the status to "needs review" if you want to get a review, see http://drupal.org/node/532400

Hi adamelleston,

Please change your git clone link it should be 'git clone http://git.drupal.org/sandbox/adamelleston/1736082.git twitter_cards'.And also please see ventral issue mentioned here 'http://ventral.org/pareview/httpgitdrupalorgsandboxadamelleston1736082git'

Mannual Review
I have gone through your module and everything seems to be ok...

Thanks
Suhani Jain

Using http://groups.drupal.org/node/184389 and http://drupal.org/node/894256 as a template for this review.

README.txt

Check, file contains adequate information

project page

Please take a moment to make your project page follow tips for a great project page.

Master Branch

Nope. Branches match naming conventions.

Major coding standards / best practice issues

An automated review of your project has found no issues with your code. Ran through coder and the automated system at ventral.org

License

No License file, check.

access administration vs. administer site configuration

Irrelevant, this project implements it's own permissions.

files[] without classes or interfaces

None, check.

Licensing issues

No License file, check.

Multiple Applications

It appears that there have been multiple project applications opened under your username:
Flickr pull: http://drupal.org/node/1525264

Idle Application

Nope, still active.

Code too short

This project meets the minimum 120 line requirement.

Duplicate module

Potentially:
nico059 implements this with the metatag module: http://drupal.org/sandbox/nico059/1741784

I think once the Project page gets updated and we confirm that this module is formally different than nico059's module, you'll be good to go.

You should also choose whether you want this module or your Flickr pull module to be reviewed for full project access, it isn't necessary to have multiple sandbox projects apply since once one is approved you are able to submit full projects without needing to go through this review process.

Attaching screenshots of Coder results and ventral.org results.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1525264
Project 2: http://drupal.org/node/1772594

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Project Page

The summary is short by sweet. The features is not a bulleted list, but that's just a recommendation anyways. Overall the project page looks good.

Multiple Applications

The other application from this user has been marked as duplicate since he will only be working on this because of time constraints.

Duplicate module

It looks like the similar module on @nico059's sandbox will most likely end up ad being a part of the meta tags module itself. I don't use Meta tags on several sites so a stand alone option for twitter cards sounds good to me.

I found no issues with the code, so I'd say this application is good to go, at least from my point of view.

Review of the 7.x-1.x branch:

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./README.txt:            ASCII text, with CRLF line terminators
  README.txt
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   20 | ERROR | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. twitter_cards_install(): no need to set variables on installation as you can use default values with variable_get() anyway. I suggest to remove that function.
2. twitter_cards_settings(): "'#title' => t($value->name),": this is vulnerable to XSS exploits. If I enter <script>alert('XSS');</script> as content type label I get a nasty javascript popup on the settings page. You need to sanitize user provided input before printing, if it has not been sanitized already. Please read http://drupal.org/node/28984 again.
3. Suggestion: currently the body field is hard coded -- I think the text field should be configurable per content type.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

a

Please don't remove the security tag, we keep that for statistical purposes and to show examples of security problems.

Changing status

Oh great, another Twitter module. It's been a few days since we had a new one ;-)

Make sure you're not duplicating functionnality and please update the linked wiki page with your module info.

It would appear as though the Meta Tags module now supports this functionality.

Does this module distinguish itself in a meaningful way from the Meta Tags module's implementation?

There is a git tag that has the same name as the branch 7.x-1.0. Make sure to remove this tag to avoid confusion.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Changed the git clone string