attached the code for spain support.

gz/tgz,... can't be attached so I'll put two comments with the other files. I dont know how to make a patch for this case, if it's possible.

CommentFileSizeAuthor
#2 cck_address_spain.module.txt6.63 KBjonhattan
#1 cck_address_spain.install.txt1.35 KBjonhattan
cck_address_spain.info242 bytesjonhattan

Comments

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new cck_address_spain.install.txt1.35 KB

.install

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new cck_address_spain.module.txt6.63 KB

.module

rconstantine’s picture

rconstantine commented

In your info file, change the first line to this: ; $Id:$ as the drupal packager fills in the data itself.

Likewise in the other two files; i.e. $id:$ within a comment.

Also, in your install file, change There was an error removing the CCK_Address database tables. to the more appropriate version I mention in response to the Indian install file submission found in another thread here in the issue queue. I need to change it in the Canadian version as well, but haven't had a chance yet.

I noticed in your module file that you comment out most of the validation fields. Is this intentional? If so, please explain. I'm sure you have a good reason.

Lastly, if you have CVS access here at Drupal, I'll add you to the project right away. If not, please petition to get it as a co-maintainer of this project.

Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Category: feature » bug

¡Gran trabajo!
En los nombres de las provincias he visto un fallo, sería la provincia de "Las Palmas de Gran Canaria" en vez de "Las Palmas"

Saludos y gracias por crear la extensión

rconstantine’s picture

rconstantine commented
Category: bug » feature
Status: Reviewed & tested by the community » Needs review

What? Why is this a bug report now? Switching back to feature request. I'm trying to fix this set of files myself, but I don't have an answer for the biggest question - why are the validation routines commented out?

rconstantine’s picture

rconstantine commented
Status: Needs review » Closed (fixed)

I added this to the project despite my outstanding question.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented

rconstantine: I'm very sorry for responding too late. I just give a chance to cck_address for testing on a project I was involved, it was so easy to extend it with another country that I did but I decided to go doing my own content-type for the project so at present I don't use this module nor have any plan to use it.

On the other hand I'm not familiar with cvs commits, someday I will apply although I'm not interested at all in co-maintaining a module I don't use.

jmesam pointed at #4 that there's a bug: the province "Las Palmas" is correctly called "Las Palmas de Gran Canaria" although I live here and the long name sucks :)-

On why I commented out the validation code... because I dint find it necessary for me, but I forgot to uncomment before commitment. I think it's too restrictive. At a second glance, at least 'º' is commonly used here, as

C/ Ramón y Cajal, nº 17 ; 3ºD

cheers