Posted by tstoeckler on September 4, 2012 at 11:24am
3 followers
| Project: | Libraries API |
| Version: | 7.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | tstoeckler |
| Status: | closed (fixed) |
Issue Summary
This is only to keep the D7 and D8 as much as possible in sync (for now!). Since there is no more /profile folder in D8, we need to get the profile path with drupal_get_path(). That is perfectly valid in D7 as well, and probably best practice anyway.
I couldn't resist to sneak 2 minor clean-ups in:
- There was a missing hyphen in the .info description
- I remove the $directory === 'libraries' variable, since it cannot be altered anyway, and I don't think we will be changing that anytime soon (and it wouldn't be that big of a patch anyway...).
In case this comes back green I will commit this pretty quick, so I can move on with the D8 port.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| libraries-prepare-d8-port.patch | 2.65 KB | Idle | PASSED: [[SimpleTest]]: [MySQL] 135 pass(es). | View details |
Comments
#1
I reviewed this again in order to then commit it, and the fact that we sometimes do file_exists() and sometimes not bothered me so I looked into that. We do a is_dir() below anyway, so I removed that. Sorry for the scope-screep.
#2
Nope, that was borked. This is the one I wanted to post.
#3
Committed to 7.x-2.x and 7.x-3.x
http://drupalcode.org/project/libraries.git/commit/11cc44f286cb5a8e61fc1...
#4
Thanks, looks good! :)
#5
Automatically closed -- issue fixed for 2 weeks with no activity.