Posted by Dasha_V on September 4, 2012 at 3:42pm
3 followers
| Project: | Metatag |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Problem
Goto the "Meta tags » Defaults » Views" admin page:
/admin/config/search/metatags/config/views
These errors appear after clicking "Save":
- The Description is using the following invalid tokens: [view:description].
- The Title is using the following invalid tokens: [view:title].
- The Canonical URL is using the following invalid tokens: [view:url].
Proposed resolution
Temporary fix - to patch metatag.module, attached.
Remaining tasks
Need review, need better solution, e.g. move "token types" option to the configuration in the hook_metatag_config_instance_info().
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| allow_view_tokens.patch | 1.77 KB | Ignored: Check issue status. | None | None |
Comments
#1
#2
New patch with fixes after additional testing other metatags pages
#3
I think actually #1894880: token_get_entity_mapping() should fallback to the entity type if token type not found is a better solution to fix this in Token module.
#4
Also we should rename the context from 'views' to 'view'. The context should match the same syntax as the other entity types, which are not plural.
#5
Renamed context from 'views' to 'view'.
#6
Moving to the meta tags issue queue to fix metatag.admin.inc.
#7
Fixed in 7.x-1.x with http://drupalcode.org/project/metatag.git/commit/a19db4b and will be included in the next Meta tag release.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.