Hi!
I found a severe bug in the new media module 2.x.
Reproduce
1. Activate a custom theme
2. Activate Admin theme, but disable admin theme when editing content in the theme settings
3. Click on the "Edit media" button in the media widget.
Result
The CSS files from the current active admin theme will be loaded over the current theme and will corrupt the current theme.
Source
The media button misses the theme_callback in hook_menu. All other media dialog fields have this implemented.
Patch to fix this:
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | add-missing-theme-callback-1774038-2.patch | 374 bytes | devin carlson |
| media_theme_callback_edit_dialog.patch | 608 bytes | ayalon |
Comments
Comment #2
devin carlson commentedA re-roll of the patch in the original issue.
Comment #3
bforchhammer commentedShouldn't the patch also adjust hook_admin_paths() and move the edit path into the if condition next to media-browser paths, or was that left out on purpose? As far as I understand, using that theme callback means that we'd essentially treat them the same...
On a different note: this issue seems to be a duplicate of #1456246: Remove media/*/edit/* as administrative path. The problem is the same as far as I can tell, but the proposed solution is a different one. It may be better to consolidate discussion in one of them (the other one is older but I don't mind which one).
Comment #4
ParisLiakos commentedi tried the patch but i have the same problem.and i cleared the cache ofc.
anyway this is duplicate of the issue mentioned above