Closed (fixed)
Project:
DraggableViews
Version:
6.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Sep 2012 at 09:06 UTC
Updated:
25 Apr 2013 at 07:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
istryker commentedDrupal does not support PHP 5.4 yet. Changing the priority
Comment #2
NaX commentedThis is a big deal to me so I did some digging. After a frustrating few hours of stepping through code I changed one character in draggableviews_theme.inc and it started working.
From:
To:
It looks like the reference
&was missing.Comment #3
RStrydom commented#2 Fix worked for me.
Attached re-rolled as patch -- built against DraggableViews 6.x-3.5 tested with views 6.x-2.16
Comment #4
faboulaws commentedThank you for posting.I had the same issue and guess what ?you are a saviour. You should know that the frustrating few hours you have spent is helping other people.
Comment #5
NaX commented@faboulaws
Thanks for the words of encouragement. I think we would should let the project maintainer decide when the issue is considered committed and fixed.
Considering this completely prevents the usage of the module in a newer PHP version I am bumping the Priority back to major. The longer we leave PHP incompatibilities like this the bigger the problem becomes with more installations being setup with code that will through errors and break.
Ref: http://drupal.org/requirements
Comment #6
istryker commentedCommitted b0d93f9 to 6.x-3.x-dev. Does this effect 7.x-2.x?
Comment #7
NaX commentedGreat thanks.
I had a look and I cant find the same problem in 7.x-2.x. I think it only affects 6.x.
Do you think this kind of problem deserves rolling a new release?