Hi Jakob,

I am very enthusiastic about filefield because I see its potential to gently overcome limitations of other file upload modules. It's giving me a headache though - I installed the new 5.2 release today and it is essentially not working at all. In Firefox, the ajax file upload results in an error message pop up containing the pages HTML code - though the file ultimately gets uploaded. in MSIE, the upload just goes on forever, I assume the ajax part of reporting back to the browser doesn't quite work.

I am also not seeing any improvements to the user interface. I don't know what to expect, but I can't detect any changes to the previous version (which I was having trouble with, too, because files weren't actually downloadabe.. probably due to an incompatibility with filemanager module or private downloads in general. Now that I am mentioning it: Making filefield unobtrusively support filemanager when it is activated would be a massive enhancement...)

I was wondering if there isn't supposed to be any .js file and any filetype icons included in the release tarball?

Comments

jpetso’s picture

jpetso commented
Status: Active » Fixed

Ah, this might be the one thing that I missed in the upgrade path:
For the AJAX stuff to work, the menu path for the JavaScript handler has to work, and it seems like those are not regenerated on a version update. Guess I should have included an update function that clears the menu cache, which is very likely to be the cause of the AJAX stuff not working for you.

In the meantime, it seems you need to clear the menu cache manually to make it work: either disable and re-enable the module, or do it with the shortcut link in the Devel module's block, or just empty the cache_menu table. That should do for solving this problem.

There's no .js file needed as filefield just reuses progress.js and upload.js from core without any changes.

Filetype icons are not included as there hasn't been a reasonably complete, license compatible icon set, and I'm also not satisfied with the appoach of determining the filetype icons. (They should depend on the mimetype instead of the extension, and fall back to a more generic icon if the specific one does not exist, and be left out if there is no icon that fits.) So before including an iconset, I want to fix this to a more reasonable state, and include a few base icons then. However, there are a few icon sets (with differing quality and completeness) lying around in the issue queue, dropping some icons from there into the ico/ directory probably does the job for now.

About the user interface... er... could it be that filefield-5.x-1.x also used the upload.module style UI? In that case, I apologize for announcing a better user interface, as I only started with filefield HEAD when it was in between of the previous 1.x and the current 2.0, and the UI was, well, you know, terrible. So if the 1.x one was a clone of the upload.module UI (like 2.0 also is) then I'm sorry for causing great expectations.

Thanks for your feedback, I'm going to adapt the release notes accordingly.

About supporting filemanager: yes, sounds like a good idea, but I'm not going to have time for doing this myself (for the time being, at least). I can test patches if they come in, but I can't code it myself for now.

Rhino25782’s picture

Rhino25782 commented

Thank you for your follow-up and clarifications. Disabling and re-enabling the module did the trick for Firefox - works like a charm. File uploads are still not working with MSIE though - the progress animation just runs infinitely. Any ideas what might be causing this behaviour?

With respect to filemanager - I am still moderately new to Drupal and not a professional developer, but I had a look at both the filemanager API and filefield functions and it seems like a doable job, so if I get around to it, I might give it a shot.

Rhino25782’s picture

Rhino25782 commented
Status: Fixed » Active
Rhino25782’s picture

Rhino25782 commented
Status: Active » Closed (fixed)

MSIE problem was due to a custom theme script error. Issue closed.

jpetso’s picture

jpetso commented

Phew. There's nothing as frightening as the thought of debugging IE quirks for a module that uses JavaScript from core which is supposed to be cross-browser compatible. What a relief :)