Closed (fixed)
Project:
Menu Icons
Version:
7.x-3.x-dev
Component:
Documentation
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Sep 2012 at 21:56 UTC
Updated:
16 Oct 2012 at 23:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
jtherkel commentedThis is my attempt at a patch. I'm a newbie to patching on D.O. Please let me know if you have any suggestions.
Comment #2
jenlamptonJohn, thanks for the patch!
In general, when you add a patch to an issue you should change the status from 'active' to 'needs review' so that the maintainers know there's a patch here for review & also so there's no need to add the tag 'Attaching patch' :)
This patch won't apply cleanly to the 7.x-3.x-dev branch for me, but I don't actually see a reason why. Otherwise, it looks great! I re-rolled the patch and the new one applies for me.
John, do you want to see if this patch applies cleanly for you, and if so mark the issue "reviewed & tested by the community"
Comment #3
acrollet commentedCommitted in http://drupalcode.org/project/menu_icons.git/commit/3189779, thanks!