Remove theme_user_list() from core

Nothing simpler than that. :)

Fixed tests - test assumes that block content is rendered
Do not use $user :)

Nice work. I

Ideally, the block content would be an array containing the Who's online text (as a #markup) and then the list. The use of #prefix is discouraged. Since that ugliness predates this patch, I'm fine with going right to RTBC as is.

Nice. Committed/pushed to 8.x.

This will need a change notification, ideally we'd have a single one for "removed theme functions" that'll work for #1598886: Clean up pager theme functions and similar too.

We are now over thresholds on critical tasks, so this and other issues with outstanding change notices are blocking features in D8. Please fix.

+++ b/core/modules/user/user.moduleundefined
@@ -848,10 +845,15 @@ function user_block_view($delta = '') {
+        $block['content'] = array(
+          '#theme' => 'item_list__user__new',
+          '#items' => array(),
+        );

@@ -864,17 +866,22 @@ function user_block_view($delta = '') {
+        $block['subject'] = t('Who\'s online');
+        $block['content'] = array(
+          '#theme' => 'item_list__user__online',
+          '#items' => array(),
+          '#prefix' => '<p>' . format_plural($authenticated_count, 'There is currently 1 user online.', 'There are currently @count users online.') . '</p>',
+        );
 

Changelog should point that user_list now exposed as renderable array and there's no theme_user_list in core

+++ b/core/modules/user/user.moduleundefined
@@ -1082,30 +1089,6 @@ function theme_username($variables) {
-function theme_user_list($variables) {

deprecated theme_* function

Thanks @andypost. Setting back to active and tagging for someone to write the change notification. (Include @andypost's points above and see #6. )

#9 first(may be last :) ) try in http://drupal.org/node/1795832

better title and status

Suppose http://drupal.org/node/1795832 is a good idea because we need a place for all removed theme functions

Recategorizing.