look in the docs please and follow the rules.

CommentFileSizeAuthor
#9 winliveid_cvs_version.patch5.45 KBhass

Comments

panis’s picture

panis commented
Category: bug » task
Priority: Normal » Minor
panis’s picture

panis commented
Component: Code » Miscellaneous
Status: Active » Closed (fixed)
hass’s picture

hass commented
Status: Closed (fixed) » Active

Where can i find the code style fixes?

panis’s picture

panis commented
Status: Active » Postponed (maintainer needs more info)

sorry that should have gone to needs more info - give me a few examples of where it does not meet coding style..

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Active

Not difficult. Every second line or nearly every line does not meet the drupal code style rules.

http://drupal.org/coding-standards

dman’s picture

dman commented

A sightly more constructive suggestion would be to install and use coder.module which will enumerate all the current problems and suggest fixes :-)
It's picky and paranoid ... but once you've cleared that you know it's valid!

"every second line" probably just refers to the use of tabs. Fix that and the style errors will drop from hundreds to dozens.

hass’s picture

hass commented
Version: 5.x-1.0 » 5.x-1.x-dev
Status: Active » Needs review

EDIT: Damn, i reviewed the wrong project... removed the patch.

hass’s picture

hass commented
Status: Needs review » Active
hass’s picture

hass commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new winliveid_cvs_version.patch5.45 KB

This should give you an idea... i have only fixed the first ~100 lines. No more. This patch is against CVS branch

hass’s picture

hass commented

Aside D6 help section contains bugs

panis’s picture

panis commented
Status: Needs review » Fixed

coding convention and help section changes updated in 5.x and 6.x

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.