Code style...

hass - September 22, 2007 - 14:17
Project:Windows Live ID Integration
Version:6.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:minor
Assigned:Unassigned
Status:closed
Description

look in the docs please and follow the rules.

#1

panis - September 25, 2007 - 14:04
Category:bug report» task
Priority:normal» minor

#2

panis - January 2, 2008 - 10:59
Component:Code» Miscellaneous
Status:active» closed

#3

hass - January 2, 2008 - 17:23
Status:closed» active

Where can i find the code style fixes?

#4

panis - January 2, 2008 - 23:06
Status:active» postponed (maintainer needs more info)

sorry that should have gone to needs more info - give me a few examples of where it does not meet coding style..

#5

hass - January 3, 2008 - 01:03
Status:postponed (maintainer needs more info)» active

Not difficult. Every second line or nearly every line does not meet the drupal code style rules.

http://drupal.org/coding-standards

#6

dman - January 3, 2008 - 01:14

A sightly more constructive suggestion would be to install and use coder.module which will enumerate all the current problems and suggest fixes :-)
It's picky and paranoid ... but once you've cleared that you know it's valid!

"every second line" probably just refers to the use of tabs. Fix that and the style errors will drop from hundreds to dozens.

#7

hass - January 3, 2008 - 08:27
Version:5.x-1.0» 5.x-1.x-dev
Status:active» needs review

EDIT: Damn, i reviewed the wrong project... removed the patch.

#8

hass - January 3, 2008 - 08:28
Status:needs review» active

#9

hass - January 3, 2008 - 08:37
Version:5.x-1.x-dev» 6.x-1.x-dev
Status:active» needs review

This should give you an idea... i have only fixed the first ~100 lines. No more. This patch is against CVS branch

AttachmentSize
winliveid_cvs_version.patch 5.45 KB

#10

hass - January 3, 2008 - 08:38

Aside D6 help section contains bugs

#11

panis - January 7, 2008 - 15:06
Status:needs review» fixed

coding convention and help section changes updated in 5.x and 6.x

#12

Anonymous (not verified) - January 21, 2008 - 15:11
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.