In views we can now choose to hide contextual links. For or against this in admin views?

CommentFileSizeAuthor
#1 admin_views-hide-admin-links.patch3.33 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new admin_views-hide-admin-links.patch3.33 KB

Like this...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

That's an interesting question :)

Most often, I really like the contextual links, because it's often not clear which exact view + display is generating the output on a particular page.

However, the counter-argument is probably that most users don't want or need to adjust the administrative views (as long as they work).

I'm undecided. Leaning more towards removing them, but I don't really know.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Remove contextual links from rendered view » Remove contextual links from admin views
Component: Miscellaneous » User interface
Category: feature » task
Status: Needs review » Reviewed & tested by the community

I think this makes sense.

Administrative views are a bit more special, since the typical user who has access to administer views probably rather cares about "front-end" views - not so much about administrative views.

So let's do this and see how it goes. :)

Not sure whether the patch still applies, but should be easy to re-roll and commit.

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Yeah, I think this makes sense still.

Applied ok, committed to 7.x-1.x :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Active 
 $handler->display->display_options['defaults']['hide_admin_links'] = FALSE;
+$handler->display->display_options['hide_admin_links'] = TRUE;

Heh :)

I just looked through the commit log once more and saw that all of the views have a default value for hide_admin_links that is the opposite...? :)

Sorry for not noticing that earlier.

damiankloip’s picture

damiankloip commented

Ah, yeah that can be confusing :)

The 'defaults' array in the display options dictates whether a value can be overridden, and as master display can't have contextual links turned off like some other, it will always be HERE. It basically just means this can be overridden on the current display. So I think this is correct.

EDIT: Basically, this means "Should I use the default value here, No, ok then" :)

damiankloip’s picture

damiankloip commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

my-family’s picture

my-family commented

Only a small note. First I didn't see contextual links in the admin_views_user view (/admin/people page). I set it to "hide" and then back in the view UI and they appeared.