Refactoring of DrupalSolrOnlineWebTestCase to be used by Others

I guess the test bot failed because there's no solr test instance, right?

How can we achieve that?
If I run the test locally, everything works fine!
Are you sure that a solr test instance is available for the test bot?

DrupalSolrOnlineWebTestCase.patch queued for re-testing.

$this->assertTrue($this->solr->ping(), "The Server could be Pinged");

Fatal error: Call to a member function ping() on a non-object in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/apachesolr/tests/solr_index_and_search.test on line 152

I did not change the logic of the tests. I just split an additional base class which could be used by others.
In my local setup, all tests pass.

For me it seems that the test instance has no local jetty server to access.

What can we do to debug this?

See attachment for my local result.

OK. What has to be done to accept my patch and to disable the test bot again for my re-written solr-dependent test?

this is really crazy: let the tests succeed if they could not be run!

But ok, here's the patch that satisfies the drupal.org test bot.

Could probably test once in setUp instead of in each place and set a class variable?

I don't think so. You have to check in every single test, because the only way to prevent the tests from running is to let the setup fail.

Therefore I created the instance variable which is set in setUp and is easier to check than doing these three lines every time:

$env_id = apachesolr_default_environment();
$environment = apachesolr_environment_load($env_id);
if (apachesolr_server_status($environment['url'])) {
...
}

class AbstractDrupalSolrOnlineWebTestCase extends DrupalWebTestCase
{
   function setUp() {
     $args = func_get_args();
     $args[] = 'apachesolr';
     $args[] = 'apachesolr_search';
     $args[] = 'search';

     call_user_func_array('parent::setUp', $args);
  }
}

DrupalWebTestCase::setUp() expects the modules to be enabled as separate arguments. Test Cases extending AbstractDrupalSolrOnlineWebTestCase might add more modules than 'apachesolr', 'apachesolr_search' and 'search' which are required at least. For example 'apachesolr_multilingual' or 'apachesolr_confgen'.

I don't know any different way than this implementation to call parent::setUp() with static and dynamic patameters that ends in a call like this:

  parent::setUp('apachesolr', 'apachesolr_search', 'search', 'apachesolr_multilingual', 'apachesolr_confgen');

Ah, I was not aware that DrupalWebTestCase accepts a single array now.

BTW any idea why the d.o test bot uses apachesolr 7.x-1.0-beta19? see http://qa.drupal.org/pifr/test/343468

#20 and #25 are missing in 6.x-3.x

committed to git