Closed (fixed)
Project:
Lost & found issues
Component:
Twig templates
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
8 Sep 2012 at 22:47 UTC
Updated:
14 Oct 2012 at 19:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
shlapa commentedComment #2
podarokwrong diff
Comment #3
shlapa commentedcorrected patch
Comment #4
podarokno tabs - use whitespaces
No newline at end of file
Comment #5
shlapa commentedfixes after code review
Comment #6
shlapa commentedComment #7
podarokbetter not use restyling in patches
but I think we can RTBC here
all other code looks good
Comment #8
andypostSuppose attributes are unified in http://drupal.org/node/1727592 and probably this branch a bit outdated
Also related #1623574: Remove trailing space from form element labels and field labels (HTML nbsp)
Comment #9
podarokpostponed till #1779136: Weekly - Merge Twig sandbox with latest HEAD
Comment #10
shlapa commentedfinal version for now...
most of variables are already Attributes objects, except mentioned as FIXME in patch.
trailing space removed
Comment #11
podaroklooks good for me
waiting for #1779136: Weekly - Merge Twig sandbox with latest HEAD
Comment #12
podarokdue to #1779136: Weekly - Merge Twig sandbox with latest HEAD
need reroll
Comment #13
podarokcommited #10 to 8.x branch
Comment #14
podarokstatus
Comment #16
fabianx commentedReopened due to not having been merged correctly to front-end branch.
Needs re-roll.
Comment #17
oseldman commentedPatch from #10 applied cleanly, but field.html.twig had already been placed properly in the directory. I committed the changes to field.module.