Closed (fixed)
Project:
ZURB Foundation
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
9 Sep 2012 at 17:41 UTC
Updated:
30 Jan 2013 at 04:21 UTC
You need to install jquery update and configure it to use jquery 1.7 instead of jquery 1.5.
I don't know if we can make a theme depend on a module.
Comments
Comment #1
ishmael-sanchez commentedWhat happens if you don't? I haven't been using 1.5 and didn't notice any issue, but who knows what I might have missed. I'm strongly against making any theme depend on a module.
If need be we could always implement hook_js_alter or hook_library (I think that's what jquery update does).
Comment #2
micheas commented.on is a jquery 1.7 function that is used in various zurbfoundation fuctions.
Comment #3
micheas commentedFurthermore Jquery 1.7 is the first jquery version that supports html5 So it is more or less the version of jquery that I would use for all new sites. (unless I used jquery 1.8)
Comment #4
ishmael-sanchez commentedOk I will take a look at the hook_library function when I get a sec or feel free to assign this issue to yourself.
Comment #5
micheas commentedBased on the state of jquery_update I am more inclined to put it in documentation for the time being.
Also, it seems that if you don't use parts of the javascript functions it works without jquery_update.
Comment #6
ishmael-sanchez commentedSo I just committed this code
it checks for the jquery_update module and if it does exist it does it's thing. Otherwise it uses the jQuery version from the framework. If a sub-theme needed to it could always override this function if they needed to use older versions. Don't know if this is the most optimized but it's working.
Comment #7
micheas commentedThe only issue that I know of is that ctools ajax will not work if you are using that on any pages that are themed with foundation. (views and ajax being a big one.)
The workaround of course is to actually install jquery_update.
Comment #9
ishmael-sanchez commentedA good resource for using newer versions of jQuery http://drupal.org/node/1058168