views_module_include() still uses ctools_plugin_api_include() to load all of the views.inc files

However, instead of just stealing the parts we need, maybe we should discuss a more core-generic way to do hook_views_data().

CommentFileSizeAuthor
#7 views-1779728-7.patch1.84 KBdawehner
#5 views-1779728-5.patch1.64 KBdawehner
#3 views-1779728-3.patch1.56 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented

If views will be part of core the core version itself tells people the api version number,
so i guess for most people using hook_hook_info to load the files would work.

I'm not sure how we deal with the .views.inc files of the core modules for now, but we could include them from views.views.inc, even this is quite hacky.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Postponed

hook_hook_info() is definitely the way to go.
I'm afraid this one is blocked on having a core sandbox.

dawehner’s picture

dawehner
Primary language German
commented
Status: Postponed » Needs review
StatusFileSize
new views-1779728-3.patch1.56 KB

I would vote to get rid of the dependency ctools as soon as possible
what about

  • Implement hook_hook_info now
  • Implement a really simple version of ctools_plugin_api_include specific for views

Status: Needs review » Needs work

The last submitted patch, views-1779728-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views-1779728-5.patch1.64 KB

Let's try this time with less exceptions :)

damiankloip’s picture

damiankloip commented
Assigned: Unassigned » dawehner
Status: Needs review » Needs work

This looks pretty good to me.

The only thing is we should probably put some docs for the $api parameter on views_module_include.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views-1779728-7.patch1.84 KB

* Removed the api parameter as we don't need it anymore without templates.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Sweet

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Added a short todo and committed and pushed! Thanks for the review!

Automatically closed -- issue fixed for 2 weeks with no activity.