Give control over collapsed/open state for signup fieldstate on node creation/edit forms
rootwork - September 24, 2007 - 02:43
| Project: | Signup |
| Version: | 5.x-2.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dww |
| Status: | won't fix |
Description
This is a continuation of 159387 -- it would be great to have, in the "advanced settings" of the module, a way to be able to control whether the signup fieldset on the node creation/edit form is collapsed by default. Right now there is control for this on the fieldset that appears on the published node, but not on the node-edit form itself.
The reason for this is that site administrators might want to encourage their users to use the signup system, and in its collapsed state it is easily missed.
#1
I coded this up to see what I think... here's the patch. However, I'm not sure I like it. ;)
A) On node types that aren't signup-enabled by default, I don't think I like having the fieldset expanded, even with the setting. Sure, all you see (if you have JS enabled) is a setting with 2 radios to enable/disable signups for that node, but still, it seems to clutter the page, especially on node types that aren't normally used for signups.
B) If I made it so that the setting only effects node types that are signup-enabled by default, I can't for the life of me figure out how to clearly explain that in the help text. ;)
I had:
Ugh! ;) I think this conditional behavior would probably be better, but we need a good way to explain it if we want it...
#2
Ok, now that http://drupal.org/node/195276 is committed, I'm less concerned about the "conditional" behavior I mentioned above. Most node types will have signups disabled, in which case this fieldset is completely gone. So you only see the fieldset on node types that have signups "allowed" or "enabled", so having it expanded in those cases seems less evil. I'm still not thrilled with the wording in the previous patch (which still applies with a little fuzz), so I'm still looking for reviews/input before I commit this. Part of me thinks that if you want this to be expanded on your site, you should just talk to your friend hook_form_alter(). ;)
#3
Is there a 6.x version of this? -- ahh, yes, its right there in admin/settings/signup
#4
No, that's the setting to control if the signup form is collapsed or not. This issue is about the signup fieldset when you *edit* a node. However, in D6, this is even less of an issue since #578502: Move signup-related settings from node/N/edit to node/N/signups/settings is now done. So, I think I'm not going to provide such a weird feature. ;)