workbench_access_content.view.inc

$view->human_name = 'Workbench Access Content';

This is broken in all Workbench* modules.

CommentFileSizeAuthor
#7 1780530-workbench-views-name.patch1.74 KBagentrickard
#7 1780530-wa-views-name.patch631 bytesagentrickard
#7 1780530-wm-views-name.patch718 bytesagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Priority: Normal » Minor

Must be a Views API change.

hass’s picture

hass commented

No, this not an API change. Look into the Workbench view code, please. The Human name is an empty string. This is the pretty name that is normally shown in the Views UI, but all Workbench modules are showing the machine name (not user friendly)

See Line 13:
http://drupalcode.org/project/workbench_access.git/blob/refs/heads/7.x-1...

hass’s picture

hass commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Needs work

No patch to review.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs work » Active
hass’s picture

hass commented

Just overwrite line 13 in workbench_access_content.view.inc with the line in #0

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 1780530-wm-views-name.patch718 bytes
new 1780530-wa-views-name.patch631 bytes
new 1780530-workbench-views-name.patch1.74 KB

Patches for all three modules. To be split into separate issues by OP.

Status: Needs review » Needs work

The last submitted patch, 1780530-wm-views-name.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Reviewed & tested by the community
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Pushed to Workbench Access.

 91e69dc..f7c0c4d  7.x-1.x -> 7.x-1.x
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Project: Workbench Access » Workbench
Status: Reviewed & tested by the community » Needs review

Moving to Workbench proper.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Project: Workbench » Workbench Moderation

Fixed in Workbench.

   9113549..6857511  7.x-1.x -> 7.x-1.x

The moderation team needs to take a look, since this may also affect 2.x branch.

hass’s picture

hass commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
stevector’s picture

stevector
he/him
commented
Status: Needs review » Closed (duplicate)

This was fixed in #1630682: "My Drafts" tab should not list published content