The “choose a profile” (very first page on the wizard) page has three options and Spark is the last on the list and it is not even the default option. This seems like a redundant step – if the user is coming to install Spark, why do we give them the option to install other Drupal flavors?
Just throwing this out there - Perhaps, we can eliminate this step together (I don't know if it is possible) and take the user directly to the language selection page?)
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | spark-install-1780598-10.patch | 868 bytes | webchick |
| #9 | spark-install-1780598-5.patch | 760 bytes | webchick |
| #5 | spark-install-1780598-5.patch | 760 bytes | David_Rothstein |
| #2 | drupal-7.16-dev-remove-profiles.patch | 22.78 KB | webchick |
Comments
Comment #1
webchickThis is a good idea. I'm not sure if it's possible, since we don't have modules yet and therefore can't do hook_form_alter() on that form.
We could skip the profile step entirely by incorporating a core hack to remove all of the default install profiles in core. I will mull that over and see if it's worth the maintenance burden (we'd have to update the patch each time a new version of Drupal core came out).
Comment #2
webchickHere's what that patch would look like.
Interestingly, if we fix this, we also end up fixing #1780588: Spark is almost impossible to install for non English speaking users. because the language screen ends up as the first screen. Hmmm!
Comment #3
webchickSince this also addresses #1780588: Spark is almost impossible to install for non English speaking users., I decided to do this.
Committed and pushed to 7.x-1.x! Thanks!
Comment #4
webchickComment #5
David_Rothstein commentedI'd suggest the attached patch instead. It's a much, much, much smaller core hack. (If you apply it along with the bug fix at #1074108: Profile selection form not skipped if there is only one visible profile it should work fine.)
Or, wait for #1727430: Add 'exclusive' flag to install profiles to auto-select them during installation. and then no core hacks are needed at all.
Comment #6
webchickHa, that is definitely a MUCH better approach, thanks. I'll take a look at those dependent issues a bit later today.
Comment #7
dcmistry commentedYou guys ROCK!
Comment #8
webchickAwesome, thanks for the pointer to those issues. I've re-rolled both patches.
Of the two approaches, I think the patch in #5 + the bug-fix in #1074108: Profile selection form not skipped if there is only one visible profile feels like the safer bet. I think #1727430: Add 'exclusive' flag to install profiles to auto-select them during installation. is going to need a bit more thought/discussion before it's ready for D7.
So I went ahead and committed / pushed this to 7.x-1.x. Thanks!
Comment #9
webchickHere's David's patch for 8.x so we can use it on the 8.x-1.x branch.
Comment #10
webchickAhem. Let's try that again.
Comment #12
japerryJust a note here for other distros that use this patch to skip the profile selection page. #1727430: Add 'exclusive' flag to install profiles to auto-select them during installation. is fixed, so you shouldn't need this patch anymore.