Download & Extend

Remove support for editablefields module

Project:Ubercart
Version:7.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D6

Issue Summary

Just wondering how it works. I didn't find this hook in views module.

<?php
/**
* Implements hook_views_tables_alter().
*
* Conditionally adds editablefields support.
*/
function uc_product_views_tables_alter(&$tables) {
?>

Comments

#1

This is legacy code from 5.x-1.x. I have not tested it in 7.x-3.x and am not convinced it will even work in 6.x-2.x.

#2

Title:Support for editablefields module» Fix or remove support for editablefields module
Category:support request» task

#3

See also #611038: Support for editablefields which suggests this code should just be removed.

#4

Title:Fix or remove support for editablefields module» Remove support for editablefields module
Status:active» needs review

Here is the issue in views module #105620: Allow modules to alter the tables and arguments arrays. It was added to views_cache.inc but the file has been removed later.
Here the commit: http://drupalcode.org/project/views.git/commitdiff/582713d953d8c04ee4d42...
So lets remove this hook. I think it should be fixed in editablefields module with hook_views_data_alter().

AttachmentSizeStatusTest resultOperations
remove_support_for_editablefields_module-1780880-0.patch3.04 KBIdlePASSED: [[SimpleTest]]: [MySQL] 2,455 pass(es).View details

#5

Status:needs review» fixed

Committed to both branches, thanks.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here