Field Collection saved on presave

Inside my custom module i use hooks node_presave, node_update, node_insert but the problem is that inside this hooks i can load only new field values of "Filed Collection" field. After a little code research i have found out that inside field_collection_field_presave values are already saved to DB, so there is no way of getting previous ones... or is there?

I agree, we should do our save during insert/update, so feel free to roll a patch.

Still, comparing changes will be more difficult as usually I think, but at least you can load the original collections during presave then - yep.

in current dev
* fieldcollecitons are saved in field_collection_field_presave().
* old revisions are marked archived in field_collection_field_update() then.

according to "field_attach_insert":http://api.drupal.org/api/drupal/modules%21field%21field.attach.inc/func... hooks are:
* field_default_[op]()
* hook_field_[op]()
* hook_field_storage_pre_insert
* (storage)_field_storage_write

so looks like hook_field_storage_pre_insert() is a good point.

Based on #1 and #3, attempted a patch - this is not my area of expertise, but I did my best to combine the proposed update hook in #1 with what was already in the module, and moved some presave code to the insert hook instead.

+++ b/field_collection.moduleundefined
@@ -888,21 +888,40 @@ function field_collection_field_settings_form($field, $instance) {
+        $item = array('value' => $entity->item_id, 'revision_id' => $entity->revision_id);

I would put the array in two lines like

$item = array(
  'value' => $entity->item_id,
  'revision_id' => $entity->revision_id,
);

Patch at #12 applies cleanly and appears to work for me. It's very useful - it allows non Entity API aware modules like Workbench Moderation to set the default_revision status of the host entity before the field collection is saved.

Hmm ... moving this logic to hook_field_update causes the Workbench Moderation problem at #1807460: Field collection doesn't play nice with workbench moderation (patch) to become worse - the first revision of the field collection will be the only revision you ever save?

Isn't this code at line 930 in field_collection_field_update() redundant? Won't any new entity already have passed through field_collection_field_insert() and have had its host entity set there?

  if (!empty($entity->is_new)) {
    $entity->setHostEntity($host_entity_type, $host_entity, LANGUAGE_NONE, FALSE);
  }

For the code that follows that, it would be tremendously useful (in Drupal 7) if workflow modules could affect how entity revisions are dealt with. As it stands, the only way to do that is in hook_entity_presave(), but that has a couple of problems for modules like Workbench Moderation:

1 - field_collection_item_get_host_entity() returns a wrapped node, where the dynamic properties set by Workbench Moderation are not accessible.

2 - To save a draft revision, Workbench Moderation saves the node again in a shutdown function with $node->revision set to 0. This causes field_collection_field_update() to remove items, as noted in #1807460: Field collection doesn't play nice with workbench moderation (patch). But the patch proposed there adds workbench_moderation-specific code.

I propose the addition of an alter hook before $entity->save, and (maybe) some modification of the following item-removal logic. This would allow other modules to cleanly modify $entity, $host_entity and $original_by_id, and avoid the need to add workbench_moderation-specific checks to this module, or field_collection-specific logic to workbench_moderation. Further customization could be handled by a dedicated module - see Field Collection Workbench Moderation

Something like the attached (which also removes the redundant hostEntity check).

Duh. So maybe we do need the extra hostEntity check...

Re queueing ... OK then.

Unassigning kscheirer. Does anyone feel the proposed alter() hook should be a separate issue? It's a harmless addition because it requires explicit implementation to do anything. I think it's within the general spirit of the issue summary, but providing some additional flexibility beyond the reach of Entity API.

Patch at #17 won't do the job, because $item['entity'] isn't always present and therefore the alter hook will not always be called. This new patch is less far-reaching, and just provides the opportunity to alter how deletions are handled.

Modules wishing to intervene in hook_entity_presave() with host entity properties fully available can still do so by caching the host entity in an earlier hook.

Cancel my request for a new hook, as per the comment by @hass. Reattaching the patch from @Niremizov at #12, marking RTBC.

Thanks, patch looks good. Committed.

Finally this was committed, thanks fago! :)

get following error when try to save node after patching module:

 PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'field_metro_target_id' cannot be null: INSERT INTO {field_data_field_metro} (entity_type, entity_id, revision_id, bundle, delta, language, field_metro_target_id) 

where "field_data_field_metro" is a collection field with not required fields.

This patch breaks functionality for rules and tokens.
I created a rule where I'm trying to use values of multifield/multivalue field collection.
Example:

[entityform:field-form-guest-collection:0:field-fcol-guest-name]
[entityform:field-form-guest-collection:0:field-fcol-guest-company]
[entityform:field-form-guest-collection:1:field-fcol-guest-name]
[entityform:field-form-guest-collection:1:field-fcol-guest-company]

If I'll change field_collection_field_update back to field_collection_field_presave, the values are populated normally.
Otherwise they are just empty values.

Patch to restore the generation of tokens as per comment 26

Hi,

Perhaps I'm missing something, but I try to compare original FC values with new FC values in hook_node_update and I always get the new values, I can't see the old ones.

$node->my_field_collection matches exactly $node->original->my_field_collection

I use entity_metadata_wrapper to populate actual values of the field collection (instead fc ids).

What would be the proper way to access original field_collection values?

EDIT:

Ok, for some reason I wasn't getting the updated results of the applied patch, even after clearing cache.
Long story short, the new values can be found in $node->my_field_collection, whereas $node->original->my_field_collection contains fc id which can be loaded to retrieve old values.

Patch from #27 added tokens for me, but I encountered another issue:

EntityMetadataWrapperException: Unable to get the data property field_myfield as the parent data structure is not set. in EntityStructureWrapper->getPropertyValue() (line 438 of /path_to_site/sites/all/modules/entity/includes/entity.wrapper.inc).

This doesn't seem to be related to issue https://www.drupal.org/node/2186689 (which results in the same error), because I'm not deleting any field collection item in my rule.

I still have to try this on the clean site to be sure it's not environment-specific.

Not sure if this is my exact issue or not so I apologize ahead of time if I'm barking up the wrong tree...

Basically, in hook_node_presave I'd like to compare node values that are about to be saved and depending on that, insert new FC values.

function mymodule_node_presave($node){
  $time = time();
    $now = array(
      'value' => $time,
      'timezone' => 'America/Los_Angeles',
      'timezone_db' => 'America/Los_Angeles',
      'date_type' => 'datestamp',
    );
 $orig_count = isset($node->original->field_thing_count['und'][0]['value']) ? $node->original->field_thing_count['und'][0]['value'] : '';
  $new_count = isset($node->field_thing_count['und'][0]['value']) ? $node->field_thing_count['und'][0]['value'] : '';
  if(!empty($orig_count) && !empty($new_count)){
    if($new_count > $orig_count){
      $change = $new_count - $orig_count;
      $already_existing_change = !empty($node->field_thing_change['und'][0]['value']) ? $node->field_thing_change['und'][0]['value'] : 0;
      $node->field_thing_change['und'][0]['value'] = $already_existing_change + $change;
    }
// Apparently, this will not work.  I'm including it so you can tell what I'd like to do.
// Perhaps hook_entity_presave??
      $field_collection_value = entity_create('field_collection_item', array('field_name' => 'field_import_info'));
      $field_collection_value->setHostEntity('node', $node);
      $field_collection_value->field_import_date['und'][] = $now
      $field_collection_value->field_change['und'][] = array('value' => $existing_change + $change);
      $field_collection_value->save();
}

Thanks for any advice.

@AaronELBorg Even I wish to save field collection in hook_node_presave. Were you able to do that?? Thanks