Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Similar to the Export UI, dead_arm has gotten the dropbutton code to a stable point, and it has a core issue: #1608878: Add CTools dropbutton to core
To remove the CTools dependency in the meantime, we can add it as a submodule.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | views-ui-1781406-19.patch | 1.9 KB | tim.plunkett |
| #8 | views-1781406-8.patch | 34.1 KB | tim.plunkett |
| #7 | views-1781406-7.patch | 20.08 KB | tim.plunkett |
| #6 | views-1781406-6.patch | 17.4 KB | tim.plunkett |
| #5 | views-1781406-5.patch | 17.43 KB | nod_ |
Comments
Comment #1
tim.plunkettThere's a sandbox branch for this: http://drupalcode.org/sandbox/damiankloip/1685040.git/shortlog/refs/head...
Comment #2
tim.plunkettThe diffstat in that patch includes the addition of the core code, here's what it would be without that:
8 files changed, 24 insertions(+), 349 deletions(-):D
Comment #3
tim.plunkettOkay, not worth doing now since it's hopefully going in soon, but here's a patch to use the new core stuff, as of #102
Comment #4
tim.plunkettUpdated patch.
Comment #5
nod_Keeping up with latest core patch:
Changed in admin.inc:
to
Comment #6
tim.plunkettUpdated for ViewUI addition
Comment #7
tim.plunkettBetter update.
Comment #8
tim.plunkettThe core dropbutton issue has been stalled yet again, and we cannot continue to wait.
Let's do what we did for core listings, and just move the current implementation in as a submodule.
We can track the progress as it happens, and remove it when the time comes.
Here is the diffstat without the added submodule: 12 files changed, 144 insertions(+), 441 deletions(-)
Even then some of that includes the seven/bartik specific theming.
Comment #9
tim.plunkettPushed!
http://drupalcode.org/project/views.git/commit/c498685
Back to postponed for eventual removal.
Comment #10
tim.plunkettYAYYYYYYY
http://drupalcode.org/project/views.git/commit/0caa3da
Comment #11
dawehnerawesome! Really great work!
Comment #12
aspilicious commentedHmm do we rly need the custom styling?
+.views-ui-display-tab-actions .dropbutton-wrapper input:hover {
background: none;
border: none;
}
Comment #13
tim.plunkettEnough has changed in core, we could probably do an inventory of those remaining styles.
Comment #14
xjmComment #15
dead_armThis is a duplicate of #1799498: Improve dropbutton now that Views is in Core.
Comment #16
xjmI thought the issue was to remove views-specific CSS that overrides base dropbutton styling? That won't be covered by the
coreother issue. Maybe we need to postpone it on that issue?Setting active for someone to confirm.
Comment #17
tim.plunkettFair enough, postponing on #1799498: Improve dropbutton. Though as #31 points out, that issue will now have to update the Views CSS at the same time, and might reduce our overrides drastically.
Comment #18
klonos#1799498: Improve dropbutton got in, so back to active I guess.
Comment #19
tim.plunkettWell yep, a lot of this got cleaned up by other issues.
But here's the rest of cleanup we can do.
The remaining CSS is needed to:
properly position the dropbuttons inline with their bucket labels (Filter, Field, Sort, etc)
handle the INPUT elements used alongside the BUTTONs
shrink the text within the Views UI to make everything fit
Comment #21
klonos...whaaat? It came green.
Comment #22
kevin morse commented#19: views-ui-1781406-19.patch queued for re-testing.
Comment #23
jibran#19: views-ui-1781406-19.patch queued for re-testing.
Comment #40
quietone commentedThis issue was committed very early in Drupal and re-purposed to check for items missed. Instead, making a new issue for the followup work and restoring the meta data of this issue to the time it was committed.
New issue, #3270645: Do an inventory of old dropbutton styling and remove it where appropriate
Thanks