When using gmaps over SSL I get a problem in some browsers if I don't accept a certificate. 

[blocked] The page at https://example.com/my-page ran insecure content from http://maps.google.com/maps/api/js?v=3.2&language=es&sensor=false.
Uncaught ReferenceError: google is not defined

This is fixed by using HTTPS when including the API file.

CommentFileSizeAuthor
#5 gmap-ssl-support-1782066-5.patch680 bytesrattusrattus
#4 gmap-https-2.0-beta5-patched1.patch842 bytesgnindl
#1 1782066-gmaps-script-https-1.patch1.17 KBpenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 1782066-gmaps-script-https-1.patch1.17 KB

Patch against today 6.x-1.x HEAD.

joestewart’s picture

joestewart commented
Status: Needs review » Reviewed & tested by the community

patch worked as described for me.

Maintainers changes status if this is not correct.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Needs work 
 git apply --check 1782066-gmaps-script-https-1.patch
warning: gmap.module has type 100755, expected 100644
error: patch failed: gmap.module:325
error: gmap.module: patch does not apply

didn`t apply to current 6.x-1.x
need reroll

gnindl’s picture

gnindl commented
Issue summary: View changes
StatusFileSize
new gmap-https-2.0-beta5-patched1.patch842 bytes

Ported and applied patch to module version 2.0-beta5

rattusrattus’s picture

rattusrattus commented
StatusFileSize
new gmap-ssl-support-1782066-5.patch680 bytes

Here's an alternative approach to provide SSL support by not including a protocol at all