line 119:

<div class=\"clearit\">

There is no closing tag to the clearit div, which can ruin layouts. Also, this is a poor use of a div tag. If anything this should be a br tag, which is at least semantically correct.

<br class=\"clearit\" />

Comments

mrowe’s picture

mrowe commented
Assigned: Unassigned » mrowe

Committed to HEAD, thanks.

I'd dispute that it's a poor use of DIV... break tags are layout, and should go in a theme.

zach harkey’s picture

zach harkey commented

It's no more layout than an empty div tag. Shouldn't that go into the theme too? There really isn't a need for either one, especially now that there are techniques for clearing floats without structural markup.

mrowe’s picture

mrowe commented

It's not an empty div, it's a div enclosing the heading. You may be correct that it is unnecessary, but I don't know why nedjo added, so I'm not going to arbitrarily remove it. At least now it has a matching closing tag, so it is valid HTML.

Anonymous’s picture

(not verified) commented