Index file entities be with access grants from parent node if the apachesolr_access module is enabled

Hmm, that is weird - this adds more stuff to the document? Not exactly the thing we'd want?

I have the same problem - files search results from the .pdf are visible only for the admin user. Is there any proper solution for that problem ?

I had this same issue and the patch in #1 by jhedstrom fixed this nicely. Thanks!!

I think Nick_vh is just talking about the appropriateness of your comments in the patch?

This fixed the issue for me as well. Thank you so much jhedstrom!

Patch in #1 works for me, too.

Works for me.

Maybe @Nick_vh could provide some information about what's wrong with it? Is it the possibility of other fields, not just the access field, being added to the document by implementations of that hook?

The patched worked in my case too...

Thank you!

Re-roll of #1 to work with apachesolr_attachments-7.x-1.3.

I just tested this on my site and it works well with the current patch.

It would be nice to have some better code comments at least. I don't love that we're invoking this general hook when we just want to hit apachesolr_access, but on the other hand, I'm not sure it makes sense to hard-code that one call either.

As a short-term fix I'd prefer something more targeted like:

// Add node access grants from the parent node to the file so that files
// are appropriately shown or filtered out of search results based on whether
// the user can access the node they are attached to.
if ($parent_entity_type == 'node' && function_exists('apachesolr_access_apachesolr_index_document_build_node')) {
  apachesolr_access_apachesolr_index_document_build_node($filedocument, $parent_entity, $env_id);
}

Here's #14 as a patch (just tweaked the comment wrapping to fit within 80 chars). I just re-indexed and tested and it works well for our use case. Thanks @pwolanin!

I had the same problem attachment search results not displaying for non-administrator users, and I applied the patch in #15 to latest .dev and it did fix that problem. Now, non-administrator users can see search results for attachments to nodes to which they have access.

However, what if files divided into public and private fields? Just because a user has access to a node may not mean he necessarily will have access to the private file field within the node. Which means that in addition to the user's access to the parent node, we also need to check his access to the file field within the node.

If apachesolr_access was doing that, then this patch breaks it. If it wasn't, then we need further code to check access to the field that the file is attached to within the node.

Any suggestions on how to approach this?

I figured that I could implement my own access control for files as the search results are displayed. The hook to use to process apachesolr search results: hook_apachesolr_process_results()

I applied #15 and after a reindex the permissions are working correctly for us.

So I think we can call this RTBC unless we need to add some tests to this.

Hiding the old patches.

Committing to 7.x-1.x

Should be backported, ideally.