According to workbench_access.api.php

You module may place its hooks inside a file named module.workbench_access.inc for auto-loading by Drupal.

That does not work however. I get:

WD workbench_access: Failed to load required include file

Patch in comment.

CommentFileSizeAuthor
#8 does_not_auto_load_the-1783208-8.patch1.03 KBjibran
#5 workbench_access-inc-autoload-1783208-5.patch1.58 KBberenddeboer
#1 workbench_access-inc-autoload-1783208-1.patch1.29 KBberenddeboer

Comments

berenddeboer’s picture

berenddeboer commented
StatusFileSize
new workbench_access-inc-autoload-1783208-1.patch1.29 KB

Autoloading is done by workbench_access_load_include and it says:

@TODO: Allow loading from outside the module directory. However,
this should be convered by the magic loading from hook_hook_info() and
the registry system.

Here a patch so auto loading works.

berenddeboer’s picture

berenddeboer commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, workbench_access-inc-autoload-1783208-1.patch, failed testing.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Version: 7.x-1.0 » 7.x-1.x-dev

You must patch against -dev.

berenddeboer’s picture

berenddeboer commented
Status: Needs work » Needs review
StatusFileSize
new workbench_access-inc-autoload-1783208-5.patch1.58 KB

Thanks agentrickard. Here the patch against dev.

Status: Needs review » Needs work

The last submitted patch, workbench_access-inc-autoload-1783208-5.patch, failed testing.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Patch failed. Also, you cannot remove the $ from the regex in file_scan_directory(), doing so causes other failures if you have backups files in your dir.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new does_not_auto_load_the-1783208-8.patch1.03 KB

How about this?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Thanks! @agentrickard.

  • agentrickard committed 71c8140 on 7.x-1.x 
    Issue #1783208 by berenddeboer, jibran: Does not auto load the...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented